Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTMLElement is undefined in IE8 #77

Closed
pbacka opened this issue Jun 5, 2015 · 2 comments
Closed

HTMLElement is undefined in IE8 #77

pbacka opened this issue Jun 5, 2015 · 2 comments
Labels

Comments

@pbacka
Copy link

pbacka commented Jun 5, 2015

In Internet Explorer 8 condition

if ($p instanceof $ || $p.length > 0) {
    p = $p[0];
} else if (("HTMLElement" in window && $p instanceof HTMLElement) || ("Element" in window && $p instanceof Element)) {
    p = $p;
    $p = $(p);
} else {
    return $(); // return empty jQuery object
}

in getGridComponent causes error: HTMLElement is undefined.

OlegKi added a commit that referenced this issue Jun 5, 2015
the test for `instanceof HTMLElement` and for `instanceof
HTMLTableRowElement` will be used now only if the corresponding object
(`HTMLElement` or `HTMLTableRowElement`) exists in the web browser.

Thanks to @pbacka. See #77
@OlegKi
Copy link
Member

OlegKi commented Jun 5, 2015

Thank you for the bug report. I committed the corresponding fix just now. Please reload free jqGrid which you use from GitHub.

@OlegKi OlegKi added the bug label Jun 5, 2015
OlegKi added a commit that referenced this issue Jun 5, 2015
Thanks @tal. See http://stackoverflow.com/q/30667421/315935. It is
modification of [the
fix](858349a)
created for [the issue](#77)
@OlegKi
Copy link
Member

OlegKi commented Jun 12, 2015

I close the issue. You can reopen it again if you find that the problem still not solved. I prefer that the person who reports a problem confirms that the fix work and he/she close the issue. Please think about closing the issues which you post the future. Best wishes!

@OlegKi OlegKi closed this as completed Jun 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants