Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HAS_* macro names #2

Closed
spth opened this issue Jul 6, 2020 · 2 comments
Closed

HAS_* macro names #2

spth opened this issue Jul 6, 2020 · 2 comments

Comments

@spth
Copy link

spth commented Jul 6, 2020

I think the HAS_* macro names have a high risk of conflicting with user names (one can easily imagine a programmer choosing HAS_COMP or HAS_ADC for a macro referring to some feature in their software).
Maybe some kind of prefix could help?
@serisman
Copy link
Collaborator

serisman commented Jul 6, 2020

Makes sense.

I just added a _PDK prefix, so HAS_ADC is now __PDK_HAS_ADC.

Does that work?

@serisman
Copy link
Collaborator

serisman commented Jul 6, 2020

Fixed with: 4a792b6
and: 79d0ed8

@serisman serisman closed this as completed Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@serisman @spth