Merge pull request #15 from spences10/107/abstract-out-quotesjson

107/abstract out quotesjson
freeCodeCamp · Nov 28, 2017 · 4a66fd4 · 4a66fd4
2 parents d96f710 + 9bed31f
commit 4a66fd4
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 84 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -37,6 +37,7 @@
     "level": "2.0.1",
     "moment": "2.19.2",
     "node-schedule": "1.2.1",
+    "positivity-api": "1.2.0",
     "retext-english": "^3.0.0",
     "retext-sentiment": "^4.1.0",
     "snyk": "1.51.0",

diff --git a/src/api/sentiment.js b/src/api/sentiment.js
@@ -3,7 +3,8 @@ const config = require('../config')
 
 const bot = new Twit(config.twitterKeys)
 
-const randomQuote = require('../helpers/randomQuote')
+const quote = require('positivity-api')
+
 const db = require('../helpers/db')
 
 // sentiment deps
@@ -38,7 +39,7 @@ const sentimentBot = event => {
   // if polarity is negative and polarity is <= -2
   if (valence == 'negative' && polarity <= -2) {
     // get a random quote
-    const phrase = randomQuote()
+    const phrase = quote.random()
     const screen_name = event.user.screen_name
     const tweetId = event.id_str
 

diff --git a/src/helpers/quotes.json b/src/helpers/quotes.json
diff --git a/src/helpers/random.js b/src/helpers/random.js
diff --git a/src/helpers/randomQuote.js b/src/helpers/randomQuote.js