Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On Congratulating user for Day 1 or Day 100, not checking clearly whether it's Day 1 or Day 100 #15

Open
amandeepmittal opened this issue Jan 8, 2017 · 2 comments
Open

On Congratulating user for Day 1 or Day 100, not checking clearly whether it's Day 1 or Day 100 #15

amandeepmittal opened this issue Jan 8, 2017 · 2 comments
Labels
bug

Comments

@amandeepmittal
Copy link
Member

Check the condition if it's Day 1 or Day 100 to decide whether its first day or last day.
Also check the condition and exclude Day 10, no tweet should be sent on Day 10.
@QuincyLarson
Copy link
Contributor

@amandeepmittal yes - I noticed this bug when I was looking at the PR. We may be able to use a regex to check for a non-digit character after the 1.

@amandeepmittal
Copy link
Member Author

@QuincyLarson yes, @stephanie56 has done something similar. I'll check it first.

@amandeepmittal amandeepmittal mentioned this issue Jan 9, 2017
Merged
@amandeepmittal amandeepmittal mentioned this issue Mar 30, 2017
Open
@spences10 spences10 mentioned this issue Oct 3, 2017
Open
amandeepmittal pushed a commit that referenced this issue Dec 1, 2017
@spences10
Merge pull request #15 from spences10/107/abstract-out-quotesjson
4a66fd4 
107/abstract out quotesjson
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@QuincyLarson @amandeepmittal