Skip to content
This repository has been archived by the owner on Jun 9, 2023. It is now read-only.

Add category to Chapters Table schema #71

Closed
xarielx opened this issue Oct 17, 2019 · 10 comments · Fixed by #81
Closed

Add category to Chapters Table schema #71

xarielx opened this issue Oct 17, 2019 · 10 comments · Fixed by #81

Comments

@xarielx
Copy link
Contributor

xarielx commented Oct 17, 2019

This will make it easier for a user to filter the chapters by interests, i.e. sports, events. Since the current schema has description and details, a more general “category” will make it easier to find the right chapter. If the chapter wants to be a private one, a private option will be added and won’t be able to be found by filtering by category.

Solution: Add category to existing chapter table schema.

@allella
Copy link
Contributor

allella commented Oct 17, 2019

A forthcoming pull request will rename "group(s)" to "chapter(s)", but the point is the same. @nik-john and/or folks on #46 and #17 should be able to address.

@rodolfo-mendes
Copy link
Contributor

Hi @allella, do we have a PR renaming the table "groups" to "chapters"? Also, I think we should update the terminology on docs.

@allella
Copy link
Contributor

allella commented Oct 17, 2019

@rodmsmendes yes, #46 includes the rename @nik-john 's last comment there was he needed to fix some things, so that's a big pending pull request right now.

@allella allella changed the title Add category to Groups Table schema Add category to Chapters Table schema Oct 17, 2019
@rodolfo-mendes
Copy link
Contributor

@allella I checked the changed files and I didn't see modifications on ddl.sql or documentation. It looks like that @nik-john altered only the API spec.

@xarielx
Copy link
Contributor Author

xarielx commented Oct 17, 2019

@rodmsmendes that’s why I opened this issue. I did not see that in modifications of the sql or documentation file, I’m glad your check agrees with mine.

@allella
Copy link
Contributor

allella commented Oct 17, 2019

@nik-john @francocorreasosa are you guys able to answer / resolve this one in the course of #46?

@nik-john
Copy link
Contributor

@allella @xarielx I am afraid that wasn't in my list by I have gone ahead and made that change now. @xarielx Please feel free to commit to that PR with your change

@rodolfo-mendes
Copy link
Contributor

@nik-john @allella @xarielx I think the PR #46 should be merged asap. I mean, that's a first step towards the API implementation and naturally, it will raise a lot of questions and suggestions. But if we keep modifying the PR #46 it will require more revision, and we will be stuck in a loop. So, my opinion is that we should not modify the PR anymore, merge it and then create new issues.

@xarielx
Copy link
Contributor Author

xarielx commented Oct 17, 2019

@nik-john Understood, on it.

@allella
Copy link
Contributor

allella commented Oct 18, 2019

#46 was merged, so I suspect someone can create a PR for this now. I'm helping more with docs and cat herding, so I'll defer to someone more familiar with the stack.

chrismgonzalez added a commit that referenced this issue Oct 18, 2019
fix/feat/api/swagger.json fix/feat/data/ddl.sql Added category label of types tring to the schemas closes #71
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants