-
-
Notifications
You must be signed in to change notification settings - Fork 357
feat: add total to paginatedPage and clear the extra queries #2340
feat: add total to paginatedPage and clear the extra queries #2340
Conversation
Co-authored-by: Aashutosh Poudel <aashutoshpoudyal@gmail.com> Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
be906d0
to
7c5df3f
Compare
Will be affect by #2224, so I am blocking it for now |
e0af6fb
to
8015bba
Compare
Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>
8015bba
to
e3e60c2
Compare
@Sboonny would you mind if I push couple commits directly? I've made further changes to make |
Nope, feel free to 👍, remove it from draft when you are done |
@ojeytonwilliams If you could take a look and review this in spare time, with fresh pair of eyes, that'd be great. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ojeytonwilliams. I was very happy with my making @Sboonny let me know if you'd want me to make suggested changes to the |
Sorry for the delay, @gikf. I don't understand the requested changes, so part of me want to change it and find out more. But I know how obnoxious I can be, when I don't understand something. Give me tomorrow, I will try to implement it, if I can't, I will ping you. |
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
e607cf9
to
b4c9497
Compare
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com> Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>
b4c9497
to
d93ae7f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Since I pushed a bit of code, could you sign off on this @gikf ?
Also, thanks to you both for your hard work on this. I didn't expect cleaning up the Click for more button to be anywhere near this involved, but what you came up with is a big improvement.
Update README.md
).main
branch of Chapter.I am trying to observe the data, and hide the data based on if there is more data or not, and when it's complete and there is no more data, we can hide the buttons, instead of running the function again to find out if there is data left.
Apparently if you ruin the git history, and decide to discard the changes, for new one good commit. GitHub close the open PR and you have to open new one. 🤔 To be honest, I am missing something with how to do it cleanly with Git so no need to focus on that PR anymore, because I can't update commits to it #2294