This repository has been archived by the owner on Jun 9, 2023. It is now read-only.

Add chapter and event images #650

Merged

ojeytonwilliams merged 10 commits into freeCodeCamp:main from ahmaxed:add-images

Nov 16, 2021

Member

ahmaxed commented Jun 30, 2021

[] I have read Chapter's contributing guidelines.
[] My pull request has a descriptive title (not a vague title like Update README.md).
[] My pull request targets the master branch of Chapter.

Closes #XXXXX

gitpod-io bot commented Jun 30, 2021

ojeytonwilliams suggested changes

View reviewed changes

client/src/modules/chapters/pages/chapterPage.tsx Outdated Show resolved Hide resolved

ojeytonwilliams mentioned this pull request

feat/add images to cards #662

Closed

3 tasks

ojeytonwilliams force-pushed the add-images branch from 342140f to 513bb55 Compare

September 16, 2021 15:19

Contributor

ojeytonwilliams commented Sep 16, 2021

Hey @ahmadabdolsaheb when you've got a sec, could you check I didn't break anything crucial in the rebase?

ojeytonwilliams force-pushed the add-images branch from 513bb55 to e71b455 Compare

October 12, 2021 15:22

ahmaxed and others added 9 commits

November 15, 2021 15:06


          feat: add chapter images

ba642db


          feat(db): migrate to add images

934b44e


          fix: add image to the Chapter edit form

2003d37


          chore: remove migration

11efe58


          refactor: image -> imageUrl

47c4e49


          chore: regenerate code

fc16804


          chore: update generated code

e41a06e


          fix: lint error

450d9ec


          test: add imageUrl to Chapter creation form

f206f6a

ojeytonwilliams force-pushed the add-images branch from e71b455 to f206f6a Compare

November 15, 2021 14:32

ojeytonwilliams marked this pull request as ready for review

November 15, 2021 14:44


          fix: set alt to "" for decorative image

c4e4fb4

ojeytonwilliams merged commit 31d1b54 into freeCodeCamp:main

Contributor

allella commented Nov 16, 2021

@all-contributors add @ahmadabdolsaheb for code

allcontributors bot mentioned this pull request

docs: add ahmadabdolsaheb as a contributor for code #805

Merged

Contributor

allcontributors bot commented Nov 16, 2021

I've put up a pull request to add @ahmadabdolsaheb! 🎉

Member Author

ahmaxed commented Nov 17, 2021

Thank you :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.