Skip to content
This repository has been archived by the owner on Sep 25, 2019. It is now read-only.

The definition of complementary colors. #221

Closed
kevinsmithwebdev-zz opened this issue Aug 6, 2018 · 6 comments · Fixed by #299
Closed

The definition of complementary colors. #221

kevinsmithwebdev-zz opened this issue Aug 6, 2018 · 6 comments · Fixed by #299

Comments

@kevinsmithwebdev-zz
Copy link
Contributor

A few days ago the section on complementary colors was edited to list orange as the complementary color of blue.

This is a contentious subject with a lot of people because a lot of us (including me) were taught the outdated RYB color model in school and that kind of sticks with us. Most people do not realize that that is no longer accepted and the preference is for the additive RGB or subtractive CMY. Of course, computer graphics are based on the RGB model.

I know people get heated about this subject. People have a habit of assuming that what they were taught in second grade is the gospel truth and can't conceive that Mrs. Magillicutty could be wrong. And sadly, many people have very firm opinions on this without having researched the subject. Color theory is a very complex science and should not be thrown together willy-nilly.

I suggest changing it back to the modern scientific understanding of color, based on the RGB model - the very color model that computer monitors use. A brief note could be added to explain that this is different than what many people were taught and provide a link to relevant material. Wikipedia for example has a pretty straightforward article explaining the change.

@kevinsmithwebdev-zz
Copy link
Contributor Author

So, no one has any thoughts on this? Shall I assume that silence is consent?

@beaucarnes
Copy link
Member

You are correct. This should be changed back to how it was.

@lauren-van-sloun
Copy link
Contributor

Sorry Mrs. Magillicutty - it's time to go with the modern, scientific consensus. My vote is for the RGB model. 👍

@scissorsneedfoodtoo
Copy link
Contributor

@kevinsmithwebdev, yes, you're absolutely correct. Should have really done more reading up on the subject before I merged that PR!

Would you be interested in changing the updating the challenge description to mention the RGB model and so yellow is the complementary color again? If not, @ashera138, would you be interested in making the change?

@kevinsmithwebdev-zz
Copy link
Contributor Author

I can take care of it if it's alright - I could use the practice.

@scissorsneedfoodtoo
Copy link
Contributor

Okay! Thank you again for catching this. Looking forward to your PR 👍

kevinsmithwebdev-zz pushed a commit to kevinsmithwebdev-zz/curriculum that referenced this issue Sep 3, 2018
The old (correct) definition of complementary colors was edited to change it from
the correct RBB
model to the outdated RYB description (that many of us were
taught and school.) The challenge is
updated to use "yellow" instead of "orange".

ISSUES CLOSED: freeCodeCamp#221
kevinsmithwebdev-zz pushed a commit to kevinsmithwebdev-zz/curriculum that referenced this issue Sep 4, 2018
Previously I did a PR to fix the definitions of complementary colors to reflect
modern RGB color
theory. This is an adjustment to some of the text, getting rid of "Note:"
and rewording the first
sentence.

ISSUES CLOSED: freeCodeCamp#221
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants