Skip to content
This repository has been archived by the owner on Sep 25, 2019. It is now read-only.

Example link will open in new tab #22

Merged
merged 1 commit into from
Jun 19, 2018
Merged

Example link will open in new tab #22

merged 1 commit into from
Jun 19, 2018

Conversation

Nirajn2311
Copy link
Member

@Nirajn2311 Nirajn2311 commented Jun 16, 2018

Pre-Submission Checklist

  • Your pull request targets the staging branch of freeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

  • Tested changes locally.
  • Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes #18

Description

@Bouncey
https://learn.freecodecamp.org/responsive-web-design/basic-html-and-html5/nest-an-anchor-element-within-a-paragraph
The link will now open in new tab.
The example and description have been edited to include target attribute.

Example link will open in new tab

Final editing
@beaucarnes beaucarnes merged commit 116f8b5 into freeCodeCamp:dev Jun 19, 2018
@beaucarnes
Copy link
Member

Looks good, thanks!

@Nirajn2311 Nirajn2311 deleted the fix/link-open-in-new-page branch June 20, 2018 01:42
raisedadead pushed a commit that referenced this pull request Jun 21, 2018
Example link will open in new tab

Final editing
raisedadead pushed a commit that referenced this pull request Jun 21, 2018
Example link will open in new tab

Final editing
raisedadead pushed a commit that referenced this pull request Jun 21, 2018
Example link will open in new tab

Final editing
raisedadead pushed a commit that referenced this pull request Jun 21, 2018
Example link will open in new tab

Final editing
raisedadead pushed a commit that referenced this pull request Jun 21, 2018
Example link will open in new tab

Final editing
raisedadead pushed a commit that referenced this pull request Jun 21, 2018
## [1.2.1](v1.2.0...v1.2.1) (2018-06-21)

### Bug Fixes

* changes text to bold in the JS Algo and DS ([#20](#20)) ([999c6af](999c6af))
* example link will open in new tab ([#22](#22)) ([5815401](5815401))
* give 'Exercise Tracker' the correct id ([6de827c](6de827c))
* Remove an unnecessary line from basic javascript challenge ([#19](#19)) ([e1dfe8f](e1dfe8f))
* sample code in intro to currying ([d4cf9de](d4cf9de))
* typo errors ([#23](#23)) ([16ff132](16ff132))
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example link in lesson text opens to FCC website in same tab
2 participants