This repository has been archived by the owner on Sep 25, 2019. It is now read-only.
fix: Remove an unnecessary line from basic javascript challenge #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raisedadead
pushed a commit
that referenced
this pull request
Jun 21, 2018
raisedadead
pushed a commit
that referenced
this pull request
Jun 21, 2018
raisedadead
pushed a commit
that referenced
this pull request
Jun 21, 2018
raisedadead
pushed a commit
that referenced
this pull request
Jun 21, 2018
raisedadead
pushed a commit
that referenced
this pull request
Jun 21, 2018
## [1.2.1](v1.2.0...v1.2.1) (2018-06-21) ### Bug Fixes * changes text to bold in the JS Algo and DS ([#20](#20)) ([999c6af](999c6af)) * example link will open in new tab ([#22](#22)) ([5815401](5815401)) * give 'Exercise Tracker' the correct id ([6de827c](6de827c)) * Remove an unnecessary line from basic javascript challenge ([#19](#19)) ([e1dfe8f](e1dfe8f)) * sample code in intro to currying ([d4cf9de](d4cf9de)) * typo errors ([#23](#23)) ([16ff132](16ff132))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #17580.
The line
Here's an example of an incomplete sentence.was unnecessary and was only causing confusion. As discussed in the issue page, I felt that removing the line doesn't make the challenge any less clear but does indeed shortens the length of the challenge text.If you feel that adding the example was better idea then I will add the example. Please take a look. Thanks.