Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix browsing file names that contain percent-encoded @ symbol #2200

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix browsing file names that contain percent-encoded @ symbol #2200

wants to merge 1 commit into from
+6 −1

Commits on Apr 22, 2024

  1. Fix browsing file names with percent-encoded @ 

    This adds an encode method into the javascript code so that
users can browser the Godot docs for @globalscope and @GDscript.

The bug was mentioned in:
freeCodeCamp#1853

This adds the encoding on the frontend, rather than trying to override
filename generation in scrapers. It's possible that this will impact
other documentation sources, but I expect those would also need to have
encoded the @ as %40 in their own docs.

This doesn't use JS' encodeURI or encodeURIComponent because encodeURI
doesn't include @, and encodeURIComponent includes / which we don't
want. If there are other URL-reserved characters
that would be useful to encode, those should be easy enough to add to
the short method added here.
    @jessevanherk
    jessevanherk committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    a219675 View commit details
    Browse the repository at this point in the history