Skip to content

Commit

Permalink
chore: apply shaun's review suggestions
Browse files Browse the repository at this point in the history
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
  • Loading branch information
Nicholas Carrigan (he/him) and ShaunSHamilton committed Oct 15, 2021
1 parent ed1351a commit cef2263
Show file tree
Hide file tree
Showing 7 changed files with 23 additions and 21 deletions.
Expand Up @@ -92,7 +92,6 @@ assert(document.querySelectorAll('.text p')?.[5]?.innerText === 'The main design
</a>
</div>
</section>
--fcc-editable-region--
<section class="text">
<p class="first-paragraph">
Soon the freeCodeCamp curriculum will be 100% project-driven learning. Instead of a series of coding challenges, you'll learn through building projects - step by step. Before we get into the details, let me emphasize: we are not changing the certifications. All 6 certifications will still have the same 5 required projects. We are only changing the optional coding challenges.
Expand All @@ -115,8 +114,10 @@ assert(document.querySelectorAll('.text p')?.[5]?.innerText === 'The main design
No more walls of explanatory text. No more walls of tests. Just one
test at a time, as you build up a working project. Over the course of passing thousands of tests, you build up projects and your own understanding of coding fundamentals. There is no transition between lessons and projects, because the lessons themselves are baked into projects. And there's plenty of repetition to help you retain everything because - hey - building projects in real life has plenty of repetition.
</p>
</section>
--fcc-editable-region--

--fcc-editable-region--
</section>
</main>
</body>
</html>
Expand Down
Expand Up @@ -33,9 +33,9 @@ Your elements within the `article` element should be in the correct order.

```js
const children = document.querySelector('article')?.children;
assert(children?.[0].localName === 'h3');
assert(children?.[1].localName === 'p');
assert(children?.[2].localName === 'ul');
assert(children?.[0]?.localName === 'h3');
assert(children?.[1]?.localName === 'p');
assert(children?.[2]?.localName === 'ul');
```
Your new `h3` element should have the `class` set to `list-title`.
Expand Down
Expand Up @@ -11,12 +11,13 @@ Within your `ul` element, create six `li` elements. Give them the following cont

Then give the `h4` and `p` elements the following text content, in order:

- The first `h4` should have the text `V1 - 2014`, and the first `p` should have the text `We launched freeCodeCamp with a simple list of 15 resources, including Harvard's CS50 and Stanford's Database Class.`
- The second `h4` should have the text `V2 - 2015`, and the second `p` should have the text `We added interactive algorithm challenges.`
- The third `h4` should have the text `V3 - 2015`, and the third `p` should have the text `We added our own HTML+CSS challenges (before we'd been relying on General Assembly's Dash course for these).`
- The fourth `h4` should have the text `V4 - 2016`, and the fourth `p` should have the text `We expanded the curriculum to 3 certifications, including Front End, Back End, and Data Visualization. They each had 10 required projects, but only the Front End section had its own challenges. For the other certs, we were still using external resources like Node School.`
- The fifth `h4` should have the text `V5 - 2017`, and the fifth `p` should have the text `We added the back end and data visualization challenges.`
- The sixth `h4` should have the text `V6 - 2018`, and the sixth `p` should have the text `We launched 6 new certifications to replace our old ones. This was the biggest curriculum improvement to date.`
- `h4`: `p`
- `V1 - 2014`: `We launched freeCodeCamp with a simple list of 15 resources, including Harvard's CS50 and Stanford's Database Class.`
- `V2 - 2015`: `We added interactive algorithm challenges.`
- `V3 - 2015`: `We added our own HTML+CSS challenges (before we'd been relying on General Assembly's Dash course for these).`
- `V4 - 2016`: `We expanded the curriculum to 3 certifications, including Front End, Back End, and Data Visualization. They each had 10 required projects, but only the Front End section had its own challenges. For the other certs, we were still using external resources like Node School.`
- `V5 - 2017`: `We added the back end and data visualization challenges.`
- `V6 - 2018`: `We launched 6 new certifications to replace our old ones. This was the biggest curriculum improvement to date.`

# --hints--

Expand Down
Expand Up @@ -187,7 +187,6 @@ assert(document.querySelectorAll('.image-wrapper img')?.[2]?.getAttribute('heigh
</li>
</ul>
</article>
--fcc-editable-region--
<aside class="image-wrapper">
<img
src="https://cdn.freecodecamp.org/testable-projects-fcc/images/random-quote-machine.png"
Expand All @@ -207,8 +206,10 @@ assert(document.querySelectorAll('.image-wrapper img')?.[2]?.getAttribute('heigh
/>
<blockquote class="image-quote"></blockquote>
<img />
</aside>
--fcc-editable-region--
--fcc-editable-region--
</aside>
</section>
</main>
</body>
Expand Down
Expand Up @@ -184,7 +184,6 @@ assert(document.querySelector('.image-quote p')?.innerText === 'The millions of
</li>
</ul>
</article>
--fcc-editable-region--
<aside class="image-wrapper">
<img
src="https://cdn.freecodecamp.org/testable-projects-fcc/images/random-quote-machine.png"
Expand All @@ -202,9 +201,11 @@ assert(document.querySelector('.image-quote p')?.innerText === 'The millions of
width="400"
height="400"
/>
--fcc-editable-region--
<blockquote class="image-quote">
</blockquote>
--fcc-editable-region--
<img
src="https://cdn.freecodecamp.org/testable-projects-fcc/images/survey-form-background.jpeg"
alt="four people working on code"
Expand All @@ -214,7 +215,6 @@ assert(document.querySelector('.image-quote p')?.innerText === 'The millions of
height="400"
/>
</aside>
--fcc-editable-region--
</section>
</main>
</body>
Expand Down
Expand Up @@ -7,11 +7,11 @@ dashedName: part-57

# --description--

Give the `.text` selector a `text-align` property set to `justify.`
Give the `.text` selector a `text-align` property set to `justify`.

# --hints--

Your `.text` selector should have a `text-align` property set to `justify.`
Your `.text` selector should have a `text-align` property set to `justify`.

```js
assert(new __helpers.CSSHelp(document).getStyle('.text')?.textAlign === 'justify');
Expand Down
Expand Up @@ -11,7 +11,7 @@ A quote is not really a quote without proper quotation marks. You can add these

Create a `.quote::before` selector and set the `content` property to `"` with a space following it.

Also create a `.quote::after` selector and set the `content` property to `"` with a space preceding it.
Also, create a `.quote::after` selector and set the `content` property to `"` with a space preceding it.

# --hints--

Expand All @@ -21,10 +21,9 @@ You should have a `.quote::before` selector.
assert(new __helpers.CSSHelp(document).getStyle('.quote::before'));
```

Your `.quote::before` selector should have a `content` property set to `" `.
Your `.quote::before` selector should have a `content` property set to `'" '`.

```js
console.log(new __helpers.CSSHelp(document).getStyle('.quote::before')?.content);
assert(new __helpers.CSSHelp(document).getStyle('.quote::before')?.content?.match(/\\?\"\s/));
```
Expand All @@ -34,7 +33,7 @@ You should have a `.quote::after` selector.
assert(new __helpers.CSSHelp(document).getStyle('.quote::after'));
```
Your `.quote::after` selector should have a `content` property set to ` "`.
Your `.quote::after` selector should have a `content` property set to `' "'`.
```js
assert(new __helpers.CSSHelp(document).getStyle('.quote::after')?.content?.match(/\s\\?\"/));
Expand Down

0 comments on commit cef2263

Please sign in to comment.