New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter: Rewrite double negative #10695
Comments
@dogweather I would amenable to this change. @FreeCodeCamp/issue-moderators second opinions? |
"And keep only the elements where a given condition returns true" or something along those lines, maybe? |
"The filter method is used to create a new array by iterating through the array it is called upon and keeping only elements where a given condition returns true." I think it's important to know that .filter() makes a new array. |
Oh yeah... I was merely referring to the double negative part of the whole thing. |
I like the addition of creating a new array. How about in active voice: " This is kind of a long sentence, though. Also returning is more correct than keeping, but might be confusing to someone new to this. cc: @risachi |
Fine by me @dogweather. Let's not wordsmith this to death 👍 |
I am working on this issue. Will send a PR across :) |
Fixes issue freeCodeCamp#10695 The description of the challenge "Filter Arrays with .filter" was updated to remove double negatives from the description as pointed out in the issue freeCodeCamp#10695
Fixes issue freeCodeCamp#10695 The description of the challenge "Filter Arrays with .filter" was updated to remove double negatives from the description as pointed out in the issue freeCodeCamp#10695
Challenge Filter Arrays with filter has an issue.
The intro sentence uses a double negative:
I suggest re-writing in the positive because it's easier to read and understand. Also, it's how I happen to think of
filter
, and maybe others do too. Here I made that change, plus removed "filter" from its own definition, and changed it from passive to active voice:The filter method iterates through an array and selects elements where a given condition is true.
The text was updated successfully, but these errors were encountered: