Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beta] Clarify title for "Basic Data Structures: Copy an Array with slice()" #13110

Closed
Greenheart opened this issue Feb 3, 2017 · 10 comments
Closed
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory.

Comments

@Greenheart
Copy link
Member

Greenheart commented Feb 3, 2017

Welcome first-time open source contributors! 🏆

Challenge copy-an-array-with-slice has an issue.

The title says "Copy an Array with slice()", but the challenge could be better described as "Copy Array items using slice()" as Array.slice() not only can copy whole arrays, but can copy individual items as well.

If you want to help fixing this, the contribution guidelines can help you get started.

This is the line where you can make this change.

Feel free to come chat with us in the Contributors chat room if you have any questions - or just want to say hi!

Good luck & Happy coding! 😄 👍


Already resolved:

1. The test for this challenge does not run properly. The console gives me plenty of "Minified React Error #32", Similar to the message reported in #12656.

2. I originally thought the second test case just had a problem with formatting, but since there's nothing wrong with it, I suspect it has to do with the React error. However, I noticed that the second test could be improved with a cleaner assertion.
I suggest this line gets replaced with
"assert(/\\.slice\\(/.test(code), 'message: The <code>forecast</code> function should utilize the <code>slice()</code> method');"

@Greenheart Greenheart added beta scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. labels Feb 3, 2017
@Greenheart
Copy link
Member Author

Greenheart commented Feb 3, 2017

I can fix the test case for now, but have no idea about the React error at this time.

What do you think about # 3?

@Greenheart Greenheart changed the title [beta] Minified React Error #32 and test improvement for "Basic Data Structures: Copy an Array with slice()" [beta] Minified React Error #32 and other improvements for "Basic Data Structures: Copy an Array with slice()" Feb 3, 2017
@no-stack-dub-sack
Copy link
Member

@Greenheart There's actually a lot of challenges in this section that use the function().tostring() format, because I wrote these before I knew about accessing user code through the code variable. So there's several more that could be simplified in this way

@Greenheart
Copy link
Member Author

@no-stack-dub-sack I'd say that we fix them once they break things. Then we can focus on other issues first 😊

@no-stack-dub-sack
Copy link
Member

@Greenheart Agreed!

@AlastairTaft
Copy link

AlastairTaft commented Feb 28, 2017

Encase anyone else finds this issue. I hit this problem because I was missing a <tbody /> tag inside my <table /> element.

@systimotic
Copy link
Member

@Greenheart 1 and 2 are now fixed, only three is left. It seems like a good idea to me. Do you want to do this, or should we mark this first-timers-only? Maybe open a new issue for 3 alone?

@Greenheart
Copy link
Member Author

@systimotic This would be a good case for first-timers-only 😊

I don't think we need a new issue - I'll just edit the original post and clarify what is left to be done.

@Greenheart Greenheart added first timers only Open for anyone doing contributions for first time. You do not need permission to work on these. help wanted Open for all. You do not need permission to work on these. and removed tests labels Mar 3, 2017
@systimotic
Copy link
Member

First-timers only

Check out CONTRIBUTING.md to get your local development environment set up.

Change the title of the "Copy an Array with slice()" challenge to "Copy Array items using slice()"
The code for this challenge can be found here. The file is /seed/challenges/02-javascript-algorithms-and-data-structures/basic-data-structures.json, line 235.

If you need help, please go to our contributors chatroom.

Happy coding!

@Greenheart Greenheart changed the title [beta] Minified React Error #32 and other improvements for "Basic Data Structures: Copy an Array with slice()" [beta] Clarify title for "Basic Data Structures: Copy an Array with slice()" Mar 3, 2017
@Greenheart
Copy link
Member Author

@systimotic Haha looks like you're faster than me! 😉

davidmgisbert added a commit to davidmgisbert/freeCodeCamp that referenced this issue Mar 3, 2017
Clarify title for "Basic Data Structures: Copy an Array with slice()"
@systimotic systimotic added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. and removed first timers only Open for anyone doing contributions for first time. You do not need permission to work on these. help wanted Open for all. You do not need permission to work on these. labels Mar 3, 2017
@systimotic
Copy link
Member

Removed first-timers-only and help-wanted to avoid getting duplicate PR's, as we often do with first-timers-only

@QuincyLarson QuincyLarson removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Mar 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory.
Projects
None yet
5 participants