-
-
Notifications
You must be signed in to change notification settings - Fork 35.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[beta] Clarify title for "Basic Data Structures: Copy an Array with slice()" #13110
Comments
I can fix the test case for now, but have no idea about the React error at this time. What do you think about # 3? |
@Greenheart There's actually a lot of challenges in this section that use the |
@no-stack-dub-sack I'd say that we fix them once they break things. Then we can focus on other issues first 😊 |
@Greenheart Agreed! |
Encase anyone else finds this issue. I hit this problem because I was missing a |
@Greenheart 1 and 2 are now fixed, only three is left. It seems like a good idea to me. Do you want to do this, or should we mark this first-timers-only? Maybe open a new issue for 3 alone? |
@systimotic This would be a good case for first-timers-only 😊 I don't think we need a new issue - I'll just edit the original post and clarify what is left to be done. |
First-timers onlyCheck out CONTRIBUTING.md to get your local development environment set up. Change the title of the "Copy an Array with slice()" challenge to "Copy Array items using slice()" If you need help, please go to our contributors chatroom. Happy coding! |
@systimotic Haha looks like you're faster than me! 😉 |
Clarify title for "Basic Data Structures: Copy an Array with slice()"
Removed |
Welcome first-time open source contributors! 🏆
Challenge copy-an-array-with-slice has an issue.
The title says "Copy an Array with slice()", but the challenge could be better described as "Copy Array items using slice()" as
Array.slice()
not only can copy whole arrays, but can copy individual items as well.If you want to help fixing this, the contribution guidelines can help you get started.
This is the line where you can make this change.
Feel free to come chat with us in the Contributors chat room if you have any questions - or just want to say hi!
Good luck & Happy coding! 😄 👍
Already resolved:
✅
1. The test for this challenge does not run properly. The console gives me plenty of "Minified React Error #32", Similar to the message reported in #12656.✅
2. I originally thought the second test case just had a problem with formatting, but since there's nothing wrong with it, I suspect it has to do with the React error. However, I noticed that the second test could be improved with a cleaner assertion.
I suggest this line gets replaced with
"assert(/\\.slice\\(/.test(code), 'message: The <code>forecast</code> function should utilize the <code>slice()</code> method');"
The text was updated successfully, but these errors were encountered: