-
-
Notifications
You must be signed in to change notification settings - Fork 37.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate React-Redux Curriculum into FCC Codebase #16138
Migrate React-Redux Curriculum into FCC Codebase #16138
Conversation
@bonham000 updated the pull request. |
@bonham000 updated the pull request. |
4 similar comments
@bonham000 updated the pull request. |
@bonham000 updated the pull request. |
@bonham000 updated the pull request. |
@bonham000 updated the pull request. |
@no-stack-dub-sack updated the pull request. |
@bonham000 updated the pull request. |
1 similar comment
@bonham000 updated the pull request. |
β¦ge (and passes!)
4eabb78
to
cb85379
Compare
@bonham000 updated the pull request. |
@bonham000 I'm interested in helping you move over the react and redux challenges. Let me know how I can help! |
Sounds good @Ethan-Arrowood I sent you a message on Gitter. |
@bonham000 updated the pull request. |
Going to use this comment to track my textual QA of the migrated challenges. Completed Challenges: All React |
@bonham000 updated the pull request. |
@bonham000 updated the pull request. |
@bonham000 updated the pull request. |
@bonham000 updated the pull request. |
@Ethan-Arrowood sounds great! Thanks for QA'ing them. Keep updating here and we'll add medals π₯ to the passing challenges in the comment above. We've finished migrating all the challenges so this final review is the last checklist item. Thanks again for your help! |
@bonham000 I'll get through all of them today (in batches). π |
@Ethan-Arrowood updated the pull request. |
@Ethan-Arrowood updated the pull request. |
All React challenges are QA'd Redux and React-Redux coming this evening. |
@no-stack-dub-sack updated the pull request. |
@Ethan-Arrowood updated the pull request. |
Redux done. React-Redux up next π― |
@Ethan-Arrowood updated the pull request. |
|
||
if (helpers.isPromise(test)) { |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
const editor = { | ||
getValue() { return source; }, | ||
getOriginalCode() { return originalCode; } | ||
}; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
originalCode = files.indexjsx.contents; | ||
build.sources.originalCode = originalCode; | ||
} | ||
return frameTests(build); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
@@ -113,7 +113,7 @@ export const classicEditorUpdated = createAction( | |||
export const modernEditorUpdated = createAction( | |||
types.modernEditorUpdated, | |||
null, | |||
createFilesMetaCreator | |||
updateFileMetaCreator |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
@@ -101,6 +101,7 @@ const writeTestDepsToDocument = frameReady => ctx => { | |||
// default for classic challenges | |||
// should not be used for modern | |||
tests.__source = sources['index'] || ''; | |||
tests.__originalCode = sources['originalCode'] || ''; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This is continued in PR #16200 |
Key:
React Challenges:
26: Bind 'this' with an ES6 Arrow Function43: Return null to Prevent Renderingsimulate()
Redux Challenges:
18: Use the ES6 Spread Operator with ObjectsReact-Redux Challenges:
Notes
async
tests in the automated test environment (we skip them currently).editor.getOriginalCode()
to provide the original, untranspiled code string.head
andtail
code is required in the FCC editor during for some of these challenges but is currently not working.Type of Change
Description
Migrate the React-Redux Curriculum from the prototype module into the FCC codebase.
Checklist
Motivational Images