Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to Use Passport Strategies & Create New Middleware #16967

Closed
clickingmouse opened this issue Mar 27, 2018 · 19 comments · Fixed by freeCodeCamp/curriculum#103
Closed

How to Use Passport Strategies & Create New Middleware #16967

clickingmouse opened this issue Mar 27, 2018 · 19 comments · Fixed by freeCodeCamp/curriculum#103
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory.

Comments

@clickingmouse
Copy link

clickingmouse commented Mar 27, 2018

https://learn.freecodecamp.org/information-security-and-quality-assurance/advanced-node-and-express/create-new-middleware/

  1. code does not work for mongodb package 3.X needs 2.X or will get db.collection is not a function. hence this dependency needs to be more strictly enforced
    error...

  2. test no.2 does not pass even though i am pretty certain code redirects to '/'

Challenge Name

https://beta.freecodecamp.org/en/challenges/advanced-node-and-express/create-new-middleware
https://beta.freecodecamp.org/en/challenges/advanced-node-and-express/how-to-use-passport-strategies

Issue Description

Browser Information

  • Browser Name, Version:
  • Operating System:
  • Mobile, Desktop, or Tablet:

Your Code

https://tan-bow.glitch.me/

Screenshot

@raisedadead raisedadead added scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. type: codepen/projects status: waiting triage This issue needs help from moderators and users to reproduce and confirm its validity and fix. labels Mar 27, 2018
@QuincyLarson
Copy link
Contributor

@Em-Ant Please take a look at this. What are your thoughts on this? Is this something that we should fix?

@QuincyLarson QuincyLarson removed the beta label Jun 3, 2018
@Em-Ant
Copy link
Member

Em-Ant commented Jun 3, 2018

@QuincyLarson we have CORS issues (probably for all the challenges) because https;//learn.freecodecamp.com is no included in the list of allowed domains. We should check all the projects, they have different strategies for handling CORS.

istantanea_2018-06-03_20-07-05

@Em-Ant
Copy link
Member

Em-Ant commented Jun 3, 2018

Create new middleware works, allowing the new domain

istantanea_2018-06-03_20-28-12

@clickingmouse be aware that the redirection is tested searching for the text 'Home page' so you have to put it somewhere in the '/' page. Probably the test or the description could be improved.

check this: https://glitch.com/edit/#!/oasis-thief

@QuincyLarson
Copy link
Contributor

@Em-Ant Awesome! Thanks! I'm closing this issue.

@clickingmouse Can you think of a way that we could improve the challenge description so that this is less ambiguous? If so, would you be interested in opening a pull request to improve the wording?

@raditotev
Copy link
Sponsor Contributor

This is still failing if there is no "Home page" content on the index page.

@Em-Ant
Copy link
Member

Em-Ant commented Aug 5, 2018

@raditotev it's how the current test implementation works. I didn't fix that, read my comment above. The simplest solution is to specify that "Home page" is required in the description.

@mattszcz
Copy link

mattszcz commented Sep 8, 2018

This is still an issue. Needs to be re-opened.

Currently, the only way to pass this challenge is to search the FCC forum or issue tracker for this hidden solution.

@ghost
Copy link

ghost commented Sep 15, 2018

Still broken for me. I just put "Home Page" in the index.pug description. Either add that to the challenge or just fix the glitch/github clone?

screen shot 2018-09-14 at 7 09 43 pm

@Em-Ant
Copy link
Member

Em-Ant commented Sep 15, 2018

@mdwattendorf @mattszcz you are right. The test works checking that 'Home page' is in the pug template. I think we should update the challenge description specifying this requirement.

ValeraS pushed a commit to ValeraS/freeCodeCamp that referenced this issue Oct 12, 2018
ValeraS pushed a commit to ValeraS/freeCodeCamp that referenced this issue Oct 12, 2018
# [3.1.0](freeCodeCamp/curriculum@v3.0.1...v3.1.0) (2018-07-27)

### Bug Fixes

* **challenge:** syntax error in sample code snippet ([1d3e076](freeCodeCamp/curriculum@1d3e076))
* **challenge:** typos in first Basic CSS challenge test ([5e41e74](freeCodeCamp/curriculum@5e41e74))
* **challenges:** add code input space for final d3 challenge ([f0b7ea9](freeCodeCamp/curriculum@f0b7ea9))
* **challenges:** add comments to getter/setter instructions codeblock ([9e9bc27](freeCodeCamp/curriculum@9e9bc27)), closes [freeCodeCamp#92](freeCodeCamp/curriculum#92)
* **challenges:** add solution project euler 52 ([f31fe38](freeCodeCamp/curriculum@f31fe38))
* **challenges:** add solution to project euler 53 ([56d7caf](freeCodeCamp/curriculum@56d7caf))
* **challenges:** add user story to tribute page challange ([12c78d4](freeCodeCamp/curriculum@12c78d4))
* **challenges:** allows single quotes ([57dab6d](freeCodeCamp/curriculum@57dab6d))
* **challenges:** broken link ([64b93df](freeCodeCamp/curriculum@64b93df))
* **challenges:** broken link ([de30ac8](freeCodeCamp/curriculum@de30ac8)), closes [freeCodeCamp#17823](https://github.com/freeCodeCamp/curriculum/issues/17823)
* **challenges:** change del tag to s tag ([4dc7589](freeCodeCamp/curriculum@4dc7589))
* **challenges:** change green-box class margin to match red-box ([9fd5533](freeCodeCamp/curriculum@9fd5533)), closes [freeCodeCamp#169](freeCodeCamp/curriculum#169)
* **challenges:** change innerHTML to textContent ([freeCodeCamp#160](freeCodeCamp/curriculum#160)) ([06e1ba1](freeCodeCamp/curriculum@06e1ba1)), closes [freeCodeCamp#17888](freeCodeCamp#17888)
* **challenges:** fix 2nd test bug ([362fc8a](freeCodeCamp/curriculum@362fc8a)), closes [freeCodeCamp#17769](https://github.com/freeCodeCamp/curriculum/issues/17769) [freeCodeCamp#17039](https://github.com/freeCodeCamp/curriculum/issues/17039) [freeCodeCamp#16967](https://github.com/freeCodeCamp/curriculum/issues/16967)
* **challenges:** fix broken tests - es6_declarative_function ([667dba9](freeCodeCamp/curriculum@667dba9))
* **challenges:** fix challenge for fallback value of CSS variable ([3abf7ad](freeCodeCamp/curriculum@3abf7ad))
* **challenges:** fix description and tests to use sync hashing ([cfa99ef](freeCodeCamp/curriculum@cfa99ef)), closes [freeCodeCamp#119](freeCodeCamp/curriculum#119)
* **challenges:** fix initial contents ([9329543](freeCodeCamp/curriculum@9329543))
* **challenges:** fix regex (es6 : import vs require) ([f4d598f](freeCodeCamp/curriculum@f4d598f)), closes [freeCodeCamp#108](freeCodeCamp/curriculum#108)
* **challenges:** fix regex in applied visual design challenge ([freeCodeCamp#162](freeCodeCamp/curriculum#162)) ([5a34767](freeCodeCamp/curriculum@5a34767)), closes [freeCodeCamp#161](freeCodeCamp/curriculum#161) [freeCodeCamp#161](freeCodeCamp/curriculum#161)
* **challenges:** fix regex to allow redundant space characters ([8b99b8b](freeCodeCamp/curriculum@8b99b8b))
* **challenges:** fix typo in "split string into array using split" ([5b27dfd](freeCodeCamp/curriculum@5b27dfd))
* **challenges:** fix typo in a "mongodb and mongoose" challenge ([bd67a66](freeCodeCamp/curriculum@bd67a66))
* **challenges:** fix typo in a node and express challenge ([78d86a4](freeCodeCamp/curriculum@78d86a4))
* **challenges:** fix typo in findOneAndUpdate() challenge ([ab912e4](freeCodeCamp/curriculum@ab912e4))
* **challenges:** fix typo in node and express challenge ([7f3ed42](freeCodeCamp/curriculum@7f3ed42))
* **challenges:** fix typos ([82f85b0](freeCodeCamp/curriculum@82f85b0))
* **challenges:** fixed a typo in Data structures challege ([a4f810e](freeCodeCamp/curriculum@a4f810e)), closes [freeCodeCamp#17786](freeCodeCamp#17786)
* **challenges:** fixed RegEx for template literals javascript challenge ([66d8463](freeCodeCamp/curriculum@66d8463)), closes [freeCodeCamp#65](freeCodeCamp/curriculum#65)
* **challenges:** fixed regex in a challenge ([c28aac0](freeCodeCamp/curriculum@c28aac0)), closes [freeCodeCamp#17861](freeCodeCamp#17861)
* **challenges:** glitch links in backend projects now open in new tabs ([507c22d](freeCodeCamp/curriculum@507c22d)), closes [freeCodeCamp#17799](https://github.com/freeCodeCamp/curriculum/issues/17799)
* **challenges:** grammatical error ([5308332](freeCodeCamp/curriculum@5308332))
* **challenges:** improve template literal challenge instructions ([99f4b9f](freeCodeCamp/curriculum@99f4b9f))
* **challenges:** inline style semicolon consistency ([3557016](freeCodeCamp/curriculum@3557016)), closes [freeCodeCamp#17909](https://github.com/freeCodeCamp/curriculum/issues/17909)
* **challenges:** minor css grid typo ([f147430](freeCodeCamp/curriculum@f147430))
* **challenges:** moved the <em> tag inside the <p> tag ([128794d](freeCodeCamp/curriculum@128794d))
* **challenges:** remove obsolete mention of beta and update link [freeCodeCamp#144](freeCodeCamp/curriculum#144) ([59d98b8](freeCodeCamp/curriculum@59d98b8))
* **challenges:** replace assertions in authentication with socket.io ([20e3617](freeCodeCamp/curriculum@20e3617)), closes [freeCodeCamp#82](freeCodeCamp/curriculum#82)
* **challenges:** typo and grammatical error ([c1160c5](freeCodeCamp/curriculum@c1160c5))
* **challenges:** typo error ([2d3ca6d](freeCodeCamp/curriculum@2d3ca6d))
* **challenges:** typo in javascript algorithms/debugging/2 ([8286ff9](freeCodeCamp/curriculum@8286ff9))
* **challenges:** typos in some basic node and express challenges ([93277e5](freeCodeCamp/curriculum@93277e5)), closes [freeCodeCamp#113](freeCodeCamp/curriculum#113) [freeCodeCamp#114](freeCodeCamp/curriculum#114)
* clarify unclear instructions ([2a7a3fa](freeCodeCamp/curriculum@2a7a3fa))
* incomplete Sass Test ([086a4a0](freeCodeCamp/curriculum@086a4a0))
* penguin colors to match directions ([0f4b8a9](freeCodeCamp/curriculum@0f4b8a9))
* **challenges:** update pseudo-element selector syntax from CSS2 to CSS3 ([15675e8](freeCodeCamp/curriculum@15675e8))
* **challenges:** update RegEx for testcase in es6 challenge ([857b3e9](freeCodeCamp/curriculum@857b3e9))
* **challenges:** update test suite CDN link ([a311e06](freeCodeCamp/curriculum@a311e06))
* **challenges:** updated dates ([21bb9d0](freeCodeCamp/curriculum@21bb9d0)), closes [freeCodeCamp#17908](https://github.com/freeCodeCamp/curriculum/issues/17908)
* **gitignore file:** added .vscode and unpacked folder to the file ([1b8eb67](freeCodeCamp/curriculum@1b8eb67))

### Features

* **challenge:** add tests for the timestamp microservice challenge ([0cb0da8](freeCodeCamp/curriculum@0cb0da8))
@BTmathic
Copy link
Contributor

BTmathic commented Nov 4, 2018

@Em-Ant Wouldn't it be better for the test to just look at the (string) URL and split it at ".com" to check that you get "" as the second element, instead of searching for a random string on the page?

Searching for a string could fail if the page is ever changed in the future (or as it currently exists) and isn't even testing properly if that string is found on other pages, whereas the URL should always contain the route you are on.

@BTmathic
Copy link
Contributor

BTmathic commented Nov 4, 2018

(I should add, this is my first time looking at the challenges/tests so I could be missing something obvious about why this can't be done, but it just looks like jQuery with the $.get() so I imagine this would work.)

ryantimjohn added a commit to ryantimjohn/freeCodeCamp-1 that referenced this issue Feb 21, 2019
update doc to include changing '/' page title to "Home page" to conform with tests.
@iasjem
Copy link

iasjem commented Feb 25, 2019

Still broken for me. I just put "Home Page" in the index.pug description. Either add that to the challenge or just fix the glitch/github clone?

screen shot 2018-09-14 at 7 09 43 pm

I also experience the same issue for that part of Create New Middleware. This solution worked for me very well though. Code to add for views/pug/index.pug:

meta(name='description', content='A cool thing made with HyperDev. This is also the Home page')

@SkipHendriks
Copy link

I thought I'd go ahead and create a pull request for the clone. No clue if that would automatically propagate to the glitch version, but I do sure hope so. I changed the description to meta(name='description', content='Home page') Changing the test to check for an URL might be more future proof, but I highly doubt we will break the test in the future.

@kingdopamine
Copy link

Just wasted hours of my life on this challenge due to the omission of very simple information critical to passing this challenge. How can FCC not include something as simple as "change the title from 'Hello' to 'Home page' in the instructions. What a piss take. I'm furious.

@RandellDawson
Copy link
Member

@kingdopamine Would you mind creating a new issue for your complaint. The original problem this issue was created for has been resolved, so to get a fresh pair of eyes on your issue, it is best to create a new issue. Thank you.

@djasuncion
Copy link

LMAO! This is my second round on the lessons and I still got stuck on this one. Been months since my first go, we still haven't fixed this. 💃

@DanPete
Copy link

DanPete commented Apr 11, 2020

Just found the solution from here as well. Had to add 'Home page' to index.pug.

It seems that there still might not be enough direction or the glitch url is cloning an older version of the repo.

@badrabbitcuntpuncher
Copy link

badrabbitcuntpuncher commented Apr 12, 2020 via email

@pabloCabrera7
Copy link

The problem is still there, i got stuck quite a long time, hopefully I went to see the forum otherwhise coudnt notice that!
Finally resolve passing the title of Home page...

Al3busse pushed a commit to Al3busse/freeCodeCamp that referenced this issue Jul 13, 2020
Change the text that ask for the title to be "Hello" to "Home page".
This change is necessary in order to pass the "create a new middleware" challenge test, changing this wont affect current challenge tests. Its just a simple syntax change.

freeCodeCamp#16967 checkout this issue to see whats its all about.
@raisedadead raisedadead removed the status: waiting triage This issue needs help from moderators and users to reproduce and confirm its validity and fix. label Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory.
Projects
None yet