-
-
Notifications
You must be signed in to change notification settings - Fork 36k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React: Pass an Array as Props challenge clarify wording on test #18256
Comments
@peterjgrainger in the instructions it is mentioned that the user has to use |
@Nirajn2311 you are absolutely right the instructions are very concise. I am probably not clear enough in my communication. I was referring to the tests for that challenge. All of the other react challenges have tests that are very specific about what text is expected in the p tag, this seems the odd one out. If At least two people have been caught out so I can't see the harm in adding more specific text? I don't mind doing the change myself |
@peterjgrainger if you want to do the changes, you’ll have to do it in the “next” branch as that is where the curriculum contents is currently. |
@Nirajn2311 ok. I'll use the next branch |
Added PR, let me know if I've done everything right! |
Closing, as the issue got resolved in #18279 |
Describe your problem and - if possible - how to reproduce it
The last test in this challenge doesn't explain what is expected in enough detail. I came across the same issue as in #17758
I suggest fixing this by changing the text of the last test from:
The List component should render the value from the tasks prop in the p tag.
to
The List component should render the value from the tasks prop in the p tag as comma delimited text e.g.
walk dog, workout
I'm happy to do the change if the wording looks correct
Add a Link to the page with the problem
https://learn.freecodecamp.org/front-end-libraries/react/pass-an-array-as-props
Tell us about your browser and operating system
n/a
The text was updated successfully, but these errors were encountered: