Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React: Pass an Array as Props challenge clarify wording on test #18256

Closed
peterjgrainger opened this issue Oct 5, 2018 · 6 comments
Closed

Comments

@peterjgrainger
Copy link

peterjgrainger commented Oct 5, 2018

Describe your problem and - if possible - how to reproduce it

The last test in this challenge doesn't explain what is expected in enough detail. I came across the same issue as in #17758

I suggest fixing this by changing the text of the last test from:
The List component should render the value from the tasks prop in the p tag.
to
The List component should render the value from the tasks prop in the p tag as comma delimited text e.g. walk dog, workout

I'm happy to do the change if the wording looks correct

Add a Link to the page with the problem

https://learn.freecodecamp.org/front-end-libraries/react/pass-an-array-as-props

Tell us about your browser and operating system

n/a

@peterjgrainger peterjgrainger changed the title React: Pass an Array as Props React: Pass an Array as Props challenge clarify wording Oct 5, 2018
@peterjgrainger peterjgrainger changed the title React: Pass an Array as Props challenge clarify wording React: Pass an Array as Props challenge clarify wording on test Oct 5, 2018
@Nirajn2311
Copy link
Member

@peterjgrainger in the instructions it is mentioned that the user has to use join(", "), so I think that the instructions are pretty clear.

@peterjgrainger
Copy link
Author

@Nirajn2311 you are absolutely right the instructions are very concise. I am probably not clear enough in my communication. I was referring to the tests for that challenge. All of the other react challenges have tests that are very specific about what text is expected in the p tag, this seems the odd one out. If join(',') is used instead of join(', ') then it's hard to figure out what is wrong as the test checks the exact format of the text and there is no feedback on what the issue is.

At least two people have been caught out so I can't see the harm in adding more specific text?

I don't mind doing the change myself

@Nirajn2311
Copy link
Member

@peterjgrainger if you want to do the changes, you’ll have to do it in the “next” branch as that is where the curriculum contents is currently.

@peterjgrainger
Copy link
Author

@Nirajn2311 ok. I'll use the next branch

@peterjgrainger
Copy link
Author

Added PR, let me know if I've done everything right!

@ezioda004
Copy link
Contributor

Closing, as the issue got resolved in #18279

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants