Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clarify test text in line with test functionality #18279

Merged

Conversation

peterjgrainger
Copy link

Pre-Submission Checklist

  • [✓ ] Your pull request targets the staging branch of freeCodeCamp.
  • [ ✓] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • [✓ ] You have only one commit (if not, squash them into one commit).
  • [ ✓] All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

  • [✓ ] Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

  • [✓ ] Tested changes locally.
  • Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes #18256

Description

Clarify wording on React: Pass an Array as Props challenge to include that the p tag should include the list as a comma separated and updated the text displayed on failure of the test to include the same. This just helps the user figure out why the test is failing and clarifies what the test is actually testing for.

Copy link
Member

@Bouncey Bouncey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks @peterjgrainger

@Bouncey Bouncey merged commit e0e8ab8 into freeCodeCamp:next Oct 8, 2018
@Bouncey
Copy link
Member

Bouncey commented Oct 8, 2018

Thank you for your first contribution to freeCodeCamp/freeCodeCamp 👍 🎉 ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants