Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Camper News comments should be editable by their author for at least some duration of time #211

Closed
CodeNonprofit opened this issue Mar 17, 2015 · 16 comments
Closed

Camper News comments should be editable by their author for at least some duration of time #211

CodeNonprofit opened this issue Mar 17, 2015 · 16 comments
Milestone
News

Comments

@CodeNonprofit
Copy link

No description provided.

@CodeNonprofit CodeNonprofit added this to the News milestone Mar 17, 2015
@MrRenter
Copy link
Contributor

Is this still a wanted feature if so I will write it up. @CodeNonprofit @QuincyLarson

@BerkeleyTrue
Copy link
Contributor

This would also require adding the ability to search through own stories which is currently a feature not implemented.

@terakilobyte
Copy link
Contributor

All the information required to allow editing the post is currently
presented in the view, I'm failing to see why searching through own stories
is required for this.

On Thu, Mar 19, 2015 at 3:23 AM Berkeley Martinez notifications@github.com
wrote:

This would also require adding the ability to search through own stories
which is currently a feature not implemented.

—
Reply to this email directly or view it on GitHub
#211 (comment)
.

@BerkeleyTrue
Copy link
Contributor

I tried to find a past story I posted and could not. While I can just do a ctrl + f 'berkeleytrue' to find my posted stories, imagine camper news has over a thousand stories? What if my story gets buried right away and I want to edit it?

As a camper, I want to hit a link to take me to all the stories that I have posted. Here I would like to edit my stories.

Granted I rarely go to hacker news so this might be functionality that is not required. It might be the case that if a story falls off we might not want to store and/or track it. In this case stories should be editable as long as they are still visible and my previous statement is moot.

@MrRenter
Copy link
Contributor

We could just make it so the post id and the logged in author are passed
through and use them for an Ajax call. All secured up of course
On Mar 18, 2015 4:30 PM, "Berkeley Martinez" notifications@github.com
wrote:

I tried to find a past story I posted and could not. While I can just do a
ctrl + f 'berkeleytrue' to find my posted stories, imagine camper news has
over a thousand stories? What if my story gets buried right away and I want
to edit it?

As a camper, I want to hit a link to take me to all the stories that I
have posted. Here I would like to edit my stories.

Granted I rarely go to hacker news so this might be functionality that is
not required. It might be the case that if a story falls off we might not
want to store and/or track it. In this case stories should be editable as
long as they are still visible and my previous statement is moot.

—
Reply to this email directly or view it on GitHub
#211 (comment)
.

@terakilobyte
Copy link
Contributor

I'm not a fan of indefinite editing. At some point the message should be made permanent. I think any more than 10 minutes it should lock, personally.

@BerkeleyTrue
Copy link
Contributor

Cool, @MrRenter you want to give this a go?

@MrRenter
Copy link
Contributor

Yea. I'll get it done.
On Mar 18, 2015 4:44 PM, "Berkeley Martinez" notifications@github.com
wrote:

Cool, @MrRenter https://github.com/MrRenter you want to give this a go?

—
Reply to this email directly or view it on GitHub
#211 (comment)
.

@BerkeleyTrue
Copy link
Contributor

sweet.

@QuincyLarson
Copy link
Contributor

Hi MrRenter can you give us a quick status update on this? I think if the comments are editable that is sufficient, as they can leave blank comments and we can just put in the even to an empty comment.
We don't want to have to worry about handling subsequent comments.

@QuincyLarson
Copy link
Contributor

@MrRenter any progress on this?

@QuincyLarson
Copy link
Contributor

Awesome! I'll take a look when I come up for air :)

  • Quincy Larson
    "Anyone who has begun to think, places some portion of the world in
    jeopardy." - John Dewey

On Wed, Apr 8, 2015 at 1:18 PM, A.L. Drake notifications@github.com wrote:

@QuincyLarson https://github.com/QuincyLarson there is a pull request
in the hopper for it. #299
#299

—
Reply to this email directly or view it on GitHub
#211 (comment)
.

@aldraco
Copy link
Contributor

aldraco commented Apr 8, 2015

sorry, i actually misspoke. :( I thought this was a different issue as it came up in my feed. my bad.

@QuincyLarson
Copy link
Contributor

No worries. This should be easy enough to fix on my own if need be.

  • Quincy Larson
    "Anyone who has begun to think, places some portion of the world in
    jeopardy." - John Dewey

On Wed, Apr 8, 2015 at 1:22 PM, A.L. Drake notifications@github.com wrote:

sorry, i actually misspoke. :( I thought this was a different issue as it
came up in my feed. my bad.

—
Reply to this email directly or view it on GitHub
#211 (comment)
.

@QuincyLarson
Copy link
Contributor

@MrRenter I think the fix would be simple: Campers should be able to edit their comments forever. Instead of being able to delete their comments, they should be able to simply blank them out.

@MrRenter MrRenter mentioned this issue Apr 18, 2015
Merged
@MrRenter
Copy link
Contributor

Sorry this got put on the back burner but here is a working elegant solution to the issue #328

@QuincyLarson QuincyLarson added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. and removed todo labels Apr 19, 2015
@terakilobyte terakilobyte removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Apr 20, 2015
ValeraS pushed a commit to ValeraS/freeCodeCamp that referenced this issue Oct 12, 2018
@nathanhannig @scissorsneedfoodtoo
fix(challenges): adding negative integer to challenge to improve tests (
2adc516 
freeCodeCamp#211)
ValeraS pushed a commit to ValeraS/freeCodeCamp that referenced this issue Oct 12, 2018
@camperbot
chore(release): 3.2.0 [skip ci]
d2d1fdc 
# [3.2.0](freeCodeCamp/curriculum@v3.1.2...v3.2.0) (2018-09-20)

### Bug Fixes

* **challenges:** a sentence didn't make sense, so I modified it ([3d77920](freeCodeCamp/curriculum@3d77920)), closes [freeCodeCamp#18046](https://github.com/freeCodeCamp/curriculum/issues/18046)
* **challenges:** add missing test to check for for css class ([6e42f53](freeCodeCamp/curriculum@6e42f53)), closes [freeCodeCamp#254](freeCodeCamp/curriculum#254)
* **challenges:** add note at bottom of description in d3 challenge ([c60d332](freeCodeCamp/curriculum@c60d332)), closes [freeCodeCamp#17767](https://github.com/freeCodeCamp/curriculum/issues/17767)
* **challenges:** add solution, test to project euler problems ([f572324](freeCodeCamp/curriculum@f572324))
* **challenges:** add solutions to first 3 debugging challenges ([c2e5794](freeCodeCamp/curriculum@c2e5794))
* **challenges:** add test to check user is using \W in Regex ([296cf44](freeCodeCamp/curriculum@296cf44))
* **challenges:** add test to lookahead regex challenge ([e044de4](freeCodeCamp/curriculum@e044de4)), closes [freeCodeCamp#209](freeCodeCamp/curriculum#209)
* **challenges:** added code tags ([065036b](freeCodeCamp/curriculum@065036b)), closes [freeCodeCamp#18054](https://github.com/freeCodeCamp/curriculum/issues/18054)
* **challenges:** added solutions to project euler problems 28, 31 ([5e12499](freeCodeCamp/curriculum@5e12499))
* **challenges:** adding code tags to description ([57d5b55](freeCodeCamp/curriculum@57d5b55)), closes [freeCodeCamp#17911](https://github.com/freeCodeCamp/curriculum/issues/17911)
* **challenges:** adding negative integer to challenge to improve tests ([freeCodeCamp#211](freeCodeCamp/curriculum#211)) ([2adc516](freeCodeCamp/curriculum@2adc516))
* **challenges:** allow user to comment out undesired code ([72c2407](freeCodeCamp/curriculum@72c2407))
* **challenges:** challenge description is formatted and concised ([dcd8e45](freeCodeCamp/curriculum@dcd8e45))
* **challenges:** change challengeType to fix help button ([ddcc661](freeCodeCamp/curriculum@ddcc661))
* **challenges:** change definition of complementary colors ([freeCodeCamp#299](freeCodeCamp/curriculum#299)) ([c022dff](freeCodeCamp/curriculum@c022dff))
* **challenges:** check for shorthand character in regex ([freeCodeCamp#238](freeCodeCamp/curriculum#238)) ([0bf8d32](freeCodeCamp/curriculum@0bf8d32))
* **challenges:** commented output was wrong ([3cb972e](freeCodeCamp/curriculum@3cb972e))
* **challenges:** converts delete html test to regex ([d80d98d](freeCodeCamp/curriculum@d80d98d)), closes [freeCodeCamp#251](freeCodeCamp/curriculum#251)
* **challenges:** corrected challenge instructions ([159203a](freeCodeCamp/curriculum@159203a))
* **challenges:** fix [freeCodeCamp#17155](https://github.com/freeCodeCamp/curriculum/issues/17155) ([cb21e59](freeCodeCamp/curriculum@cb21e59))
* **challenges:** fix confusing destructuring es6 challenge ([1a4f6a8](freeCodeCamp/curriculum@1a4f6a8)), closes [freeCodeCamp#213](freeCodeCamp/curriculum#213)
* **challenges:** fix description in css variable fallback challenge ([bc33a03](freeCodeCamp/curriculum@bc33a03)), closes [freeCodeCamp#17546](freeCodeCamp#17546)
* **challenges:** fix flex direction row regex ([25ea07e](freeCodeCamp/curriculum@25ea07e)), closes [freeCodeCamp#260](freeCodeCamp/curriculum#260)
* **challenges:** fix grammar and spelling errors ([freeCodeCamp#244](freeCodeCamp/curriculum#244)) ([b0c0b74](freeCodeCamp/curriculum@b0c0b74))
* **challenges:** fix grid-gap shorthand regex ([freeCodeCamp#232](freeCodeCamp/curriculum#232)) ([a49f45e](freeCodeCamp/curriculum@a49f45e)), closes [freeCodeCamp#229](freeCodeCamp/curriculum#229)
* **challenges:** fix grid-gap shorthand regex ([freeCodeCamp#237](freeCodeCamp/curriculum#237)) ([b369fa0](freeCodeCamp/curriculum@b369fa0)), closes [freeCodeCamp#229](freeCodeCamp/curriculum#229)
* **challenges:** fix regex in a JS challenge ([freeCodeCamp#257](freeCodeCamp/curriculum#257)) ([6058da3](freeCodeCamp/curriculum@6058da3))
* **challenges:** fix typo in wrap-reverse description ([434ea5c](freeCodeCamp/curriculum@434ea5c))
* **challenges:** fixed challenge accepted without any new code ([96b39c1](freeCodeCamp/curriculum@96b39c1)), closes [freeCodeCamp#198](freeCodeCamp/curriculum#198)
* **challenges:** fixed esc chars in managing packages with npm lesson ([6335a15](freeCodeCamp/curriculum@6335a15))
* **challenges:** fixed tests to check for pre operators ([ded4705](freeCodeCamp/curriculum@ded4705)), closes [freeCodeCamp#199](freeCodeCamp/curriculum#199)
* **challenges:** fixed typo in algorithms and ds ([31957a4](freeCodeCamp/curriculum@31957a4))
* **challenges:** Incorrect html closing tag ([a1464f0](freeCodeCamp/curriculum@a1464f0))
* **challenges:** insufficient objectives for javascript_algorithm/es6/19 ([7707b18](freeCodeCamp/curriculum@7707b18))
* **challenges:** missing space in code example ([c50cc4e](freeCodeCamp/curriculum@c50cc4e))
* **challenges:** remove race condition from react lifecycle challenge ([a20ac56](freeCodeCamp/curriculum@a20ac56))
* **challenges:** removed duplicate css top property ([0a79c58](freeCodeCamp/curriculum@0a79c58))
* **challenges:** rephrased wording in applied visual design ([freeCodeCamp#268](freeCodeCamp/curriculum#268)) ([d560d58](freeCodeCamp/curriculum@d560d58))
* **challenges:** replaced em tags with code tags ([68daaf7](freeCodeCamp/curriculum@68daaf7)), closes [freeCodeCamp#18048](https://github.com/freeCodeCamp/curriculum/issues/18048)
* **challenges:** reword test text and improve test accuracy ([f834a98](freeCodeCamp/curriculum@f834a98))
* **challenges:** small edit to correct sematic issues ([322bf80](freeCodeCamp/curriculum@322bf80))
* clickjacking challenge description ([037990c](freeCodeCamp/curriculum@037990c))
* **challenges:** spelling and grammar errors addressed ([8f17adf](freeCodeCamp/curriculum@8f17adf))
* **challenges:** typo ([4f7faba](freeCodeCamp/curriculum@4f7faba))
* **challenges:** update test and add solution for DS challenge ([d1b2075](freeCodeCamp/curriculum@d1b2075)), closes [freeCodeCamp#164](freeCodeCamp/curriculum#164)
* **challenges:** Update test to include whitespace ([freeCodeCamp#272](freeCodeCamp/curriculum#272)) ([77689f4](freeCodeCamp/curriculum@77689f4)), closes [freeCodeCamp#271](freeCodeCamp/curriculum#271)
* **schema:** change schema and unpack script ([b014b23](freeCodeCamp/curriculum@b014b23))

### Features

* **challenges:** add browser fallback challenge ([b090e8b](freeCodeCamp/curriculum@b090e8b)), closes [freeCodeCamp#17546](freeCodeCamp#17546)
@181149 181149 mentioned this issue Jan 9, 2023
Open
@ajesse11x ajesse11x mentioned this issue Jan 9, 2023
Open
This was referenced Jan 9, 2023
Open
Open
@snyk-bot snyk-bot mentioned this issue Jan 10, 2023
Open
@ojongerius ojongerius mentioned this issue Jan 10, 2023
Open
@snyk-bot snyk-bot mentioned this issue Jan 10, 2023
Open
@zzx4998 zzx4998 mentioned this issue Jun 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
News
Development

No branches or pull requests
6 participants
@QuincyLarson @MrRenter @terakilobyte @BerkeleyTrue @CodeNonprofit @aldraco