-
-
Notifications
You must be signed in to change notification settings - Fork 36.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent Indentation in Understanding Boolean Values #34367
Labels
first timers only
Open for anyone doing contributions for first time. You do not need permission to work on these.
help wanted
Open for all. You do not need permission to work on these.
scope: curriculum
Lessons, Challenges, Projects and other Curricular Content in curriculum directory.
Comments
Hi @akkatracker, I agree, this is small bug. Would you be interested in fixing this? |
I'm happy to leave it open for a first timer ☺ |
Hi @ezioda004 I will like to take up the task |
@akkatracker Go ahead. Feel free to ask any questions if you get stuck. |
Hi @akkatracker and @ezioda004 I have fixed the inconsistency |
Fixed via #34373 |
ezioda004
pushed a commit
that referenced
this issue
Nov 18, 2018
fix the inconsistency in the formatting of the function and also fix issue #34367
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
first timers only
Open for anyone doing contributions for first time. You do not need permission to work on these.
help wanted
Open for all. You do not need permission to work on these.
scope: curriculum
Lessons, Challenges, Projects and other Curricular Content in curriculum directory.
Describe your problem and how to reproduce it:
I feel as though this question's starter code is inconsistent with all the surrounding questions, where the body of functions are indented.
The
return false
(and potentially the comments above and below it) should be indented to make the challenge consistent, and encourage good style.Add a Link to the page with the problem:
https://learn.freecodecamp.org/javascript-algorithms-and-data-structures/basic-javascript/understanding-boolean-values
Tell us about your browser and operating system:
If possible, add a screenshot here (you can drag and drop, png, jpg, gif, etc. in this box):
![image](https://user-images.githubusercontent.com/2032746/48669603-4f044a80-eb5c-11e8-9ce0-231857fd058a.png)
The text was updated successfully, but these errors were encountered: