Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent Indentation in Understanding Boolean Values #34367

Closed
mattdbr opened this issue Nov 18, 2018 · 6 comments
Closed

Inconsistent Indentation in Understanding Boolean Values #34367

mattdbr opened this issue Nov 18, 2018 · 6 comments
Labels
first timers only Open for anyone doing contributions for first time. You do not need permission to work on these. help wanted Open for all. You do not need permission to work on these. scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory.

Comments

@mattdbr
Copy link
Contributor

mattdbr commented Nov 18, 2018

Describe your problem and how to reproduce it:
I feel as though this question's starter code is inconsistent with all the surrounding questions, where the body of functions are indented.

The return false (and potentially the comments above and below it) should be indented to make the challenge consistent, and encourage good style.

Add a Link to the page with the problem:
https://learn.freecodecamp.org/javascript-algorithms-and-data-structures/basic-javascript/understanding-boolean-values

Tell us about your browser and operating system:

  • Browser Name: Chrome
  • Browser Version: Version 72.0.3613.0 (Official Build) canary (32-bit)
  • Operating System: Windows 10

If possible, add a screenshot here (you can drag and drop, png, jpg, gif, etc. in this box):
image

@ezioda004
Copy link
Contributor

Hi @akkatracker,

I agree, this is small bug. Would you be interested in fixing this?

@ezioda004 ezioda004 added the scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. label Nov 18, 2018
@Nirajn2311 Nirajn2311 added the first timers only Open for anyone doing contributions for first time. You do not need permission to work on these. label Nov 18, 2018
@mattdbr
Copy link
Contributor Author

mattdbr commented Nov 18, 2018

I'm happy to leave it open for a first timer ☺

@ezioda004 ezioda004 added the help wanted Open for all. You do not need permission to work on these. label Nov 18, 2018
@attaradev
Copy link
Contributor

Hi @ezioda004

I will like to take up the task

@ezioda004
Copy link
Contributor

@akkatracker Go ahead. Feel free to ask any questions if you get stuck.

@attaradev
Copy link
Contributor

Hi @akkatracker and @ezioda004 I have fixed the inconsistency

@ezioda004
Copy link
Contributor

Fixed via #34373

ezioda004 pushed a commit that referenced this issue Nov 18, 2018
fix the inconsistency in the formatting of the function and also fix issue #34367
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first timers only Open for anyone doing contributions for first time. You do not need permission to work on these. help wanted Open for all. You do not need permission to work on these. scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory.
Projects
None yet
Development

No branches or pull requests

4 participants