Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Learn Typography by Building a Nutrition Label - gets repetitive and a bit boring #46358

Closed
PersianBlue opened this issue Jun 5, 2022 · 6 comments
Labels
help wanted Open for all. You do not need permission to work on these. status: discussing Under discussion threads. Closed as stale after 60 days of inactivity.

Comments

@PersianBlue
Copy link

PersianBlue commented Jun 5, 2022

This isn't really a bug issue, more of a content/feature issue. I feel like it would be more intuitive if the class names (lg, md, sm-text, etc.) were spelled out to make them more intuitive, and then having understood what we were doing, we were just tasked to build each section of the nutrition label. As opposed to adding every new paragraph and divider one by one by one in this instance. Then if a person was unsure about a certain aspect of it, hints could guide them along the way.

On another note, if there's a better place to give feedback/suggestions do let me know.

image
Likewise, the code that we're adding to over time turns into a mass of pargaraph and div soup... not very easy on the eyes

@Sboonny Sboonny added the status: discussing Under discussion threads. Closed as stale after 60 days of inactivity. label Jun 6, 2022
@fullStackRacc
Copy link
Contributor

I will agree this one got a bit long, a lot like the balance sheet one.

Im not entirely sure a great solution though. The repetition is really useful for getting a bit more of an understanding tbh

I do like the idea of making the divs and classes a bit more clear/descriptive. Maybe use more sections and make the classes less condensed?

@naomi-lgbt
Copy link
Member

The repetition does help to reinforce concepts and get campers familiar with the concepts we are teaching.

PRs are certainly welcome to change the class names from lg to large - we'd also welcome a PR to adjust the flow of the project, if you're feeling ambitious.

@naomi-lgbt naomi-lgbt added the help wanted Open for all. You do not need permission to work on these. label Aug 31, 2022
@chrysillala
Copy link

Hi, can I contribute to this issue? Would appreciate if you could give some guidance, thanks!

@ilenia-magoni
Copy link
Contributor

I am going to tackle part of the issue in #47675 47675

@0xClint
Copy link

0xClint commented Oct 9, 2022

I would like to contribute, can assign me issues?

@Nirajn2311 Nirajn2311 self-assigned this Dec 12, 2022
Nirajn2311 added a commit to ilenia-magoni/freeCodeCamp that referenced this issue Dec 12, 2022
Nirajn2311 added a commit to ilenia-magoni/freeCodeCamp that referenced this issue Jan 4, 2023
@naomi-lgbt
Copy link
Member

Going to go ahead and close this one as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Open for all. You do not need permission to work on these. status: discussing Under discussion threads. Closed as stale after 60 days of inactivity.
Projects
None yet
Development

No branches or pull requests

9 participants