Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nutrition Table - Step 4 | insufficient test case #54896

Open
zxc-w opened this issue May 21, 2024 · 1 comment · May be fixed by #54904
Open

Nutrition Table - Step 4 | insufficient test case #54896

zxc-w opened this issue May 21, 2024 · 1 comment · May be fixed by #54904
Labels
help wanted Open for all. You do not need permission to work on these. scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc.

Comments

@zxc-w
Copy link
Contributor

zxc-w commented May 21, 2024 •
edited

Describe the Issue

The challenge requires using href attribute to link the styles.css file.
However, the camper will pass if he used ahref or anyThingInYourMind_href.
That's because the regex used here at the test case.

Related forum topic: Learn Typography by building a Nutrition Table Step 4

Affected Page

https://www.freecodecamp.org/learn/2022/responsive-web-design/learn-typography-by-building-a-nutrition-label/step-4

Your code

  <link rel="stylesheet" href="https://fonts.googleapis.com/css?family=Open+Sans:400,700,800">
  <link rel="stylesheet" ffdfefefdfsefefwef_href="styles.css">

Expected behavior

Prevent passing with an incorrect attribute name.

Screenshots

image

System

  • Device: [e.g. iPhone 6, Laptop]
  • OS: [e.g. iOS 14, Windows 10, Ubuntu 20.04]
  • Browser: [e.g. Chrome, Safari]
  • Version: [e.g. 22]

Additional context

No response
@zxc-w zxc-w added scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: waiting triage This issue needs help from moderators and users to reproduce and confirm its validity and fix. type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc. labels May 21, 2024
@huyenltnguyen
Copy link
Member

@zxc-w Thank you for reporting the issue.

I think the test for the styles.css link should be updated to use .getAttribute('href'), similar to how we write the second test case.

@huyenltnguyen huyenltnguyen added help wanted Open for all. You do not need permission to work on these. and removed status: waiting triage This issue needs help from moderators and users to reproduce and confirm its validity and fix. labels May 21, 2024
@Nitz2611 Nitz2611 mentioned this issue May 21, 2024
Closed
4 tasks
@Supravisor Supravisor linked a pull request May 21, 2024 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Open for all. You do not need permission to work on these. scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc.
Projects
None yet
Milestone
No milestone
2 participants
@huyenltnguyen @zxc-w