Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(curriculum) update assertion for typography link element #54904

Merged
merged 5 commits into from
Jun 21, 2024

Conversation

Supravisor
Copy link
Contributor

@Supravisor Supravisor commented May 21, 2024

Checklist:

Closes #54896

Could not use .getAttribute('href') due to leading dot in href attribute value.
Added semi-colon to close const variable in another assertion.

image

image

image

image

@github-actions github-actions bot added the scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. label May 21, 2024
@Supravisor Supravisor marked this pull request as ready for review May 21, 2024 14:51
@jdwilkin4 jdwilkin4 added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label May 22, 2024
Copy link
Member

@Sembauke Sembauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also be able to add a link to ./styles.css without a leading dot and slash: `styles.css"

@Sembauke Sembauke added status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP and removed status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. labels Jun 6, 2024
@Supravisor Supravisor requested a review from Sembauke June 8, 2024 09:50
@gikf gikf added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. and removed status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP labels Jun 17, 2024
@naomi-lgbt naomi-lgbt merged commit 76cd4ec into freeCodeCamp:main Jun 21, 2024
20 checks passed
@Supravisor Supravisor deleted the nutrition-4 branch June 22, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nutrition Table - Step 4 | insufficient test case
5 participants