Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed loopback-testing dependency from package.json #10063

Merged
merged 1 commit into from
Aug 3, 2016
Merged

Removed loopback-testing dependency from package.json #10063

merged 1 commit into from
Aug 3, 2016

Conversation

cskinner74
Copy link

Pre-Submission Checklist

  • [-] Your pull request targets the staging branch of FreeCodeCamp.
  • [-] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • [-] You have only one commit (if not, squash them into one commit).
  • [-] All new and existing tests pass the command npm run test-challenges. Use git commit --amend to amend any fixes.

Type of Change

  • [-] Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

  • [-] Tested changes locally.
  • Closes currently open issue (replace XXXX with an issue no): Closes #XXXX

Description

Removed the loopback-testing dependency from package.json

@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Aug 3, 2016
@raisedadead
Copy link
Member

raisedadead commented Aug 3, 2016

Refers #10017

@raisedadead raisedadead merged commit 58ed93b into freeCodeCamp:staging Aug 3, 2016
@raisedadead raisedadead removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Aug 3, 2016
@cskinner74 cskinner74 deleted the fix/remove-loopback-testing branch August 3, 2016 19:31
@raisedadead
Copy link
Member

@sync350 thanks!

✨ And congratulations on your first contribution to Free Code Camp. ✨

@cskinner74
Copy link
Author

@raisedadead Thank you for giving me the opportunity to contribute!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants