-
-
Notifications
You must be signed in to change notification settings - Fork 36k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vertical scrollbar for challenges instructions panel. #10469
Add vertical scrollbar for challenges instructions panel. #10469
Conversation
Tagging @QuincyLarson @hallaathrad @BerkeleyTrue for review of UX/UI changes. |
Fix indentations.
@eduardbcom updated the pull request. |
Just fixed indentations I haven't noticed before. |
@eduardbcom Thanks for submitting this PR. Can you include screen shots of how this looks in other browsers and on Windows/Linux? I think we tried adding scroll bars in the past and it resulted in duplicate scroll bars so we ditched them. Also, I don't see an issue that this is referencing. Unless there are a lot of campers asking for this sort of UI element, it's probably not worth cluttering up our UI over. |
@eduardbcom is there any progress on this? |
Closing as stale @eduardbcom feel free to reopen this PR if you have any more progress |
@Bouncey @QuincyLarson Looks like this issue reproduces just on my screen. Have tested on wider screen and it works just fine. In the next time will check this out on several devices first..by the way, my solution does not duplicate scrollbar, so it will work just fine. Many thanks for your time will continue study and contribute to FCC. |
@eduardbcom OK - what is your device's resolution? Thanks for raising this issue. We are not closed to the option of adding a scroll bar necessarily, but there are so many browsers, all of which interpret these differently, and significant cross browser and device testing would be necessary. |
Pre-Submission Checklist
staging
branch of FreeCodeCamp.fix/
,feature/
, ortranslate/
(e.g.fix/signin-issue
)npm run test-challenges
. Usegit commit --amend
to amend any fixes.Type of Change
Checklist:
Description
Add scrollbar for challenge instruction part of the page (the leftmost column).
Before fix:
![screen shot 2016-09-04 at 12 11 31 pm](https://cloud.githubusercontent.com/assets/8774679/18232575/d1ec3af4-72da-11e6-8982-773f3ab898e9.png)
After fix:
![screen shot 2016-09-04 at 12 24 34 pm](https://cloud.githubusercontent.com/assets/8774679/18232576/d71d4432-72da-11e6-809b-5dbc1c3532f6.png)