Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vertical scrollbar for challenges instructions panel. #10469

Closed
wants to merge 2 commits into from
Closed

Add vertical scrollbar for challenges instructions panel. #10469

wants to merge 2 commits into from

Conversation

eduardbme
Copy link

@eduardbme eduardbme commented Sep 4, 2016

Pre-Submission Checklist

  • Your pull request targets the staging branch of FreeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm run test-challenges. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)
  • Little front-end enchantment.

Checklist:

  • Tested changes locally.
  • Closes currently open issue (replace XXXX with an issue no): Closes #XXXX

Description

Add scrollbar for challenge instruction part of the page (the leftmost column).

Before fix:
screen shot 2016-09-04 at 12 11 31 pm

After fix:
screen shot 2016-09-04 at 12 24 34 pm

@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Sep 4, 2016
@erictleung
Copy link
Member

Tagging @QuincyLarson @hallaathrad @BerkeleyTrue for review of UX/UI changes.

@erictleung erictleung added the scope: UI Threads for addressing UX changes and improvements to user interface label Sep 4, 2016
Fix indentations.
@camperbot
Copy link
Contributor

@eduardbcom updated the pull request.

@eduardbme
Copy link
Author

Just fixed indentations I haven't noticed before.

@QuincyLarson
Copy link
Contributor

@eduardbcom Thanks for submitting this PR.

Can you include screen shots of how this looks in other browsers and on Windows/Linux? I think we tried adding scroll bars in the past and it resulted in duplicate scroll bars so we ditched them.

Also, I don't see an issue that this is referencing. Unless there are a lot of campers asking for this sort of UI element, it's probably not worth cluttering up our UI over.

@Bouncey Bouncey added status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. and removed status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. labels Sep 26, 2016
@Bouncey
Copy link
Member

Bouncey commented Sep 26, 2016

@eduardbcom is there any progress on this?

@Bouncey
Copy link
Member

Bouncey commented Sep 27, 2016

Closing as stale

@eduardbcom feel free to reopen this PR if you have any more progress

@Bouncey Bouncey closed this Sep 27, 2016
@BerkeleyTrue BerkeleyTrue removed the status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. label Sep 27, 2016
@eduardbme
Copy link
Author

eduardbme commented Sep 27, 2016

@Bouncey @QuincyLarson Looks like this issue reproduces just on my screen. Have tested on wider screen and it works just fine. In the next time will check this out on several devices first..by the way, my solution does not duplicate scrollbar, so it will work just fine.

Many thanks for your time will continue study and contribute to FCC.

@QuincyLarson
Copy link
Contributor

@eduardbcom OK - what is your device's resolution? Thanks for raising this issue. We are not closed to the option of adding a scroll bar necessarily, but there are so many browsers, all of which interpret these differently, and significant cross browser and device testing would be necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: UI Threads for addressing UX changes and improvements to user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants