Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Last Test in Bonfire Caesar Cipher #10521

Closed
wants to merge 74 commits into from
Closed

Changed Last Test in Bonfire Caesar Cipher #10521

wants to merge 74 commits into from

Conversation

wjhurley
Copy link
Contributor

@wjhurley wjhurley commented Sep 9, 2016

Pre-Submission Checklist

  • [x ] Your pull request targets the staging branch of FreeCodeCamp.
  • [x ] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • [x ] You have only one commit (if not, squash them into one commit).
  • [x ] All new and existing tests pass the command npm run test-challenges. Use git commit --amend to amend any fixes.

Type of Change

  • [x ] Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

Description

Per the comments in the open issue, I changed the last test assertion from 'THE QUICK BROWN DOG JUMPED OVER THE LAZY FOX' to 'THE QUICK BROWN DOG JUMPS OVER THE LAZY FOX' as well as the HTML displayed on the page to match the updated assertion.

Berkeley Martinez and others added 30 commits February 29, 2016 12:43
@camperbot
Copy link
Contributor

@wjhurley thanks for the PR.
You have pushed more than one commit. When you finish editing, squash your commits into one.
Please, review our Guidelines for Contributing, thank you!.

@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Sep 9, 2016
@abhisekp
Copy link
Member

abhisekp commented Sep 9, 2016

@wjhurley Please rebase the PR with the staging branch and force pushing to your branch.

@abhisekp
Copy link
Member

abhisekp commented Sep 9, 2016

@wjhurley You may use the following commands

$ git checkout fix/caesar-cipher
$ git pull -rpreserve upstream staging
# fix any conflicts
# commit the changes
$ git push -fu fix/caesar-cipher

@BerkeleyTrue BerkeleyTrue added status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. and removed status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. labels Sep 10, 2016
@wjhurley wjhurley closed this Sep 11, 2016
@BerkeleyTrue BerkeleyTrue removed the status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. label Sep 11, 2016
@wjhurley wjhurley deleted the fix/caesar-cipher branch September 12, 2016 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants