-
-
Notifications
You must be signed in to change notification settings - Fork 36k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: make links open in new window as per issue #10969 #10973
bug: make links open in new window as per issue #10969 #10973
Conversation
@alexanderholman please change your branch name to remove the issue number and then push it again with -f |
no problem |
@ dhcodes I've opened a new PR (#10978) with the new branch name, not sure if I've done that correctly? changed the name using |
That's fine. We'll just close this one. I'm not sure there was a better way since according to this you can't really use the same PR. If you deleted the branch it would remove the PR. |
Pre-Submission Checklist
staging
branch of FreeCodeCamp.fix/
,feature/
, ortranslate/
(e.g.fix/signin-issue
)npm run test-challenges
. Usegit commit --amend
to amend any fixes.Type of Change
Checklist:
Description
Added
target="blank"
to anchors on lines 4914 and 4915