Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: make links open in new window as per issue #10969 #10973

Closed
wants to merge 1 commit into from
Closed

bug: make links open in new window as per issue #10969 #10973

wants to merge 1 commit into from

Conversation

alexanderholman
Copy link
Contributor

Pre-Submission Checklist

  • Your pull request targets the staging branch of FreeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm run test-challenges. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

Description

Added target="blank" to anchors on lines 4914 and 4915

@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Sep 29, 2016
@dhcodes
Copy link
Contributor

dhcodes commented Sep 29, 2016

@alexanderholman please change your branch name to remove the issue number and then push it again with -f

@alexanderholman
Copy link
Contributor Author

no problem

@alexanderholman
Copy link
Contributor Author

@ dhcodes I've opened a new PR (#10978) with the new branch name, not sure if I've done that correctly? changed the name using git branch -m ... locally and pushed to my own repo... was there a better way to do it? e.g. a way to update the PR itself?

@dhcodes
Copy link
Contributor

dhcodes commented Sep 29, 2016

That's fine. We'll just close this one. I'm not sure there was a better way since according to this you can't really use the same PR. If you deleted the branch it would remove the PR.

@dhcodes dhcodes closed this Sep 29, 2016
@BerkeleyTrue BerkeleyTrue removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Sep 29, 2016
@alexanderholman alexanderholman deleted the fix/10969_open_links_new_window branch September 29, 2016 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants