Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated GIFs and Screenshots with up-to-date branding of FreeCodeCamp #11069

Merged
merged 1 commit into from Oct 11, 2016
Merged

Updated GIFs and Screenshots with up-to-date branding of FreeCodeCamp #11069

merged 1 commit into from Oct 11, 2016

Conversation

ghost
Copy link

@ghost ghost commented Oct 5, 2016

Pre-Submission Checklist

  • Your pull request targets the staging branch of FreeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/.
  • You have only one commit.
  • All new and existing tests pass the command npm run test-challenges.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)

Checklist:

@ghost ghost added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. hacktoberfest labels Oct 5, 2016
@dhcodes
Copy link
Contributor

dhcodes commented Oct 9, 2016

@atjonathan this lgtm, but there are still a few gifs with older branding. ex. http://beta.freecodecamp.com/en/challenges/join-the-free-code-camp-community/learn-what-to-do-if-you-get-stuck step 7/8 where the site in the gif still has the brown color scheme. I'm not sure all of them need to be updated but wanted to point it out just in case.

@ghost
Copy link
Author

ghost commented Oct 9, 2016

@dhcodes, sure 😉

@camperbot
Copy link
Contributor

@atjonathan updated the pull request.

@ghost
Copy link
Author

ghost commented Oct 9, 2016

@dhcodes, we should be good to go!

@dhcodes
Copy link
Contributor

dhcodes commented Oct 10, 2016

LGTM, can someone else test too?

@dhcodes
Copy link
Contributor

dhcodes commented Oct 11, 2016

LGTM @atjonathan. As food for thought in the future, I might recommend stripping out the loading screens between sites (ex. the 2 second white screen when loading the facebook page) on the gifs. Do you use Camtasia to make these gifs?

@dhcodes dhcodes merged commit 97aba4c into freeCodeCamp:staging Oct 11, 2016
@BerkeleyTrue BerkeleyTrue removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Oct 11, 2016
@ghost ghost deleted the fix/gifs-screenshots branch October 11, 2016 15:39
@ghost
Copy link
Author

ghost commented Oct 11, 2016

@dhcodes, I use licecap. The old gifs had loading screens so I didn't think to remove them in the new ones. When these need changed again, we can bear that in mind 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants