Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyboard shortcut for commenting back in #11329

Merged

Conversation

systimotic
Copy link
Member

@systimotic systimotic commented Oct 22, 2016

Pre-Submission Checklist

  • Your pull request targets the staging branch of FreeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm run test-challenges. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

  • Tested changes locally.
  • Closes currently open issue (replace XXXX with an issue no): Closes #XXXX

Description

On the live site, pressing Ctrl or Cmd + / comments and uncomments the code. I really love this feature. This functionality is no longer present in the beta. I did a little bit of git-digging, but I wasn't able to find where it disappeared. I decided to try to add it back in, and see if it would work. Surprisingly, it worked fine! Credits to @gangachris for originally adding this in #9854 馃憤
Edit: I wasn't sure whether this was a feature or a fix.

@ghost ghost added performance status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. and removed performance labels Oct 23, 2016
@Bouncey
Copy link
Member

Bouncey commented Oct 23, 2016

The changes look good, I will pull this done shortly to test.

@Bouncey
Copy link
Member

Bouncey commented Oct 24, 2016

LGTM 馃憤

Thanks for contributing 馃帀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants