Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update redux-actions to version 1.0.1 πŸš€ #11754

Closed
wants to merge 1 commit into from

Conversation

greenkeeperio-bot
Copy link
Contributor

Hello lovely humans,

redux-actions just published its new version 1.0.1.

State Update πŸš€
Dependency redux-actions
New version 1.0.1
Type dependency

This version is not covered by your current version range.

Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.

I recommend you look into these changes and try to get onto the latest version of redux-actions.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.

Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?

There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.

Good luck with your project ✨

You rock!

🌴


GitHub Release

With #141 we have made other libraries incompatible with redux-actions and it resulted to an unexpected behavior (#164, #167). If an action is not a FSA, handleAction should not handle it and just pass it to the next reducer. This fix will remove the FSA check to support Non-FSA.

Fixes


The new version differs by 9 commits .

  • adbccb0 1.0.1
  • ef4acb7 Remove FSA check in handleAction(s)
  • 72d7655 1.0.0
  • 227db63 standardize on invariant for runtime checks
  • f9bf59e Check type of payload creator (#129)
  • 69f69ec Enforce reducer type in handleAction (#156)
  • 26a9ccb Make defaultState required when creating reducers (#127)
  • ea04ccf fix(handleAction): Add descriptive error for missing or invalid actions (#141)
  • aaaa110 Omit payload on undefined only (#128)

See the full diff.


This pull request was created by greenkeeper.io.

Tired of seeing this sponsor message? ⚑ greenkeeper upgrade

@BerkeleyTrue BerkeleyTrue added greenkeeper status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. labels Nov 21, 2016
Copy link
Member

@Bouncey Bouncey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaks build

@Bouncey
Copy link
Member

Bouncey commented Nov 22, 2016

This update breaks our build, issue raised in redux-actions repo

Refer: redux-utilities/redux-actions#169

@Bouncey
Copy link
Member

Bouncey commented Nov 22, 2016

I tried changing null to undefined as suggested by redux-actions maintainers, this side steps the initial issue I had, but now entities-reducer.js is tripping up when submitChallenge is dispatched.

entities-reducer.js:19   Uncaught TypeError: Cannot read property 'email' of null

I have a feeling this will require a refactor of entities-reducer.js and common\app\redux\actions.js so that all the destructing of payload is handled inside of the appropriate createAction @BerkeleyTrue

@Bouncey
Copy link
Member

Bouncey commented Nov 23, 2016

Closed in favour of #11784

@Bouncey Bouncey closed this Nov 23, 2016
@Bouncey Bouncey deleted the greenkeeper-redux-actions-1.0.1 branch November 23, 2016 23:48
@BerkeleyTrue BerkeleyTrue removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Nov 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants