Revise description for Concatenate Arrays with .concat Challenge #11855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BerkeleyTrue
added
the
status: waiting review
t3h2mas
reviewed
Nov 29, 2016
|
@johnnyqbui How does the challenge description look like after this modification? Any screenshot? |
abhisekp
changed the title
johnnyqbui
force-pushed
the
fix/description
branch
from
561849d
to
d42b5c3
Compare
|
@johnnyqbui updated the pull request. |
abhisekp
suggested changes
Nov 29, 2016
| "Here are examples of <code>concat</code> being used to concatenate arrays:", | ||
| "Example 1: <code>otherArray</code> onto the end of <code>oldArray</code>:", | ||
| "<blockquote>newArray = oldArray.concat(otherArray);</blockquote>", | ||
| "Example 2: <code>newArray</code> with all values of <code>arr1, arr2,</code> and <code>arr3</code>:", |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
johnnyqbui
force-pushed
the
fix/description
branch
from
d42b5c3
to
535060f
Compare
|
@johnnyqbui updated the pull request. |
abhisekp
reviewed
Nov 29, 2016
| "Here are examples of <code>concat</code> being used to concatenate arrays:", | ||
| "Example 1: <code>otherArray</code> onto the end of <code>oldArray</code>:", | ||
| "<blockquote>newArray = oldArray.concat(otherArray);</blockquote>", | ||
| "Example 2: <code>newArray</code> with all elements of <code>arr1, arr2,</code> and <code>arr3</code>:", |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
johnnyqbui
force-pushed
the
fix/description
branch
from
535060f
to
d519fef
Compare
|
@johnnyqbui updated the pull request. |
|
@johnnyqbui updated the pull request. |
johnnyqbui
force-pushed
the
fix/description
branch
from
d519fef
to
cee59a1
Compare
|
@abhisekp Yay! my first approved PR, thanks! |
BerkeleyTrue
removed
the
status: waiting review
|
Thanks for this one. 🎉 😃 Let it keep coming. Love your work 💗 You might want to check out Writing Good Git Commit Messages Enjoy! 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Submission Checklist
stagingbranch of FreeCodeCamp.fix/,feature/, ortranslate/(e.g.fix/signin-issue)npm test. Usegit commit --amendto amend any fixes.Type of Change
Checklist:
Description
Revised description for Concatenate Arrays with .concat challenge for a more accurate description of .concat.
Fixed checklist by @abhisekp - 29th Nov. 2016 - 8:33 AM IST