Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(challenge): Additional test cases for 'Escape Sequences in Strings' #13105

Merged

Conversation

billy-reilly
Copy link
Contributor

@billy-reilly billy-reilly commented Feb 3, 2017

This is a revised PR for my previous PR #13090 with the changes requested by @Greenheart

Pre-Submission Checklist

  • Your pull request targets the staging branch of freeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

Description

Additional test cases and hints added to reduce confusion and help users find the correct solution

@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Feb 3, 2017
@Greenheart
Copy link
Member

@billy-reilly Thanks for the update!

I'm afraid I wasn't clear enough - you could just have used git commit --amend and git push origin <your-branch> -f to update the previous PR without having to reopen it.

But it's no problem, I'll just review this one ☺️

@Greenheart Greenheart self-requested a review February 3, 2017 12:34
Copy link
Member

@Greenheart Greenheart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@billy-reilly Thanks for the fix! 😄

@Greenheart Greenheart merged commit 91df7e6 into freeCodeCamp:staging Feb 3, 2017
@BerkeleyTrue BerkeleyTrue removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Feb 3, 2017
@billy-reilly billy-reilly deleted the fix/tests-escape-sequences branch February 3, 2017 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants