Make Symmetric Difference Order Invarient #1426
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One of the tests failed with @terakilobyte's solution. https://www.evernote.com/l/AnuX-4sNoL5Nlo2Ij_qy6jwjRpzth5ypagQB/image.png |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the discussion in #1402, an actual Symmetric Difference is order independent. Since it is not possible to test for arbitrary order, we instead will sort the user's answer and compare against a pre-sorted test value. This will ensure that any returned order will be correct.
I have done basic testing against chai.js's deepEqual/iterableEqual functions and this solution appears to work properly.