Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brazilian Portuguese translation of Basic HTML and HTML5 #15439

Merged
merged 3 commits into from Jun 29, 2017
Merged

Brazilian Portuguese translation of Basic HTML and HTML5 #15439

merged 3 commits into from Jun 29, 2017

Conversation

nmdoliveira
Copy link
Contributor

@nmdoliveira nmdoliveira commented Jun 19, 2017 •
edited

Pre-Submission Checklist

  • Your pull request targets the staging branch of freeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

Description

Adds Brazilian Portuguese translation of "Basic HTML and HTML5"

@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Jun 19, 2017
@nmdoliveira nmdoliveira mentioned this pull request Jun 19, 2017
Closed
28 tasks
@raisedadead
Copy link
Member

@nmdoliveira thanks for the pull request, would you mind tagging anyone who would be interested in a peer review?

Will merge if no one comes up in 7 days.

@nmdoliveira
Copy link
Contributor Author

I asked @aferreira44 to review in the issue

@aferreira44
Copy link
Contributor

Reviewed with the PR nmdoliveira#1

Great job @nmdoliveira! I change just few things, not very important.

@aferreira44 aferreira44 mentioned this pull request Jun 28, 2017
Merged
@nmdoliveira
Merge pull request #1 from aferreira44/aferreira44/translate/Pt-br-tr…
767fe74 
…anslation-basic-html-and-html5

Basic HTML and HTML5 reviewed
@camperbot
Copy link
Contributor

@nmdoliveira updated the pull request.

@raisedadead raisedadead merged commit e905b7e into freeCodeCamp:staging Jun 29, 2017
@raisedadead raisedadead removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Jun 29, 2017
mhatout pushed a commit to mhatout/freeCodeCamp that referenced this pull request Feb 9, 2018
@nmdoliveira @mhatout
Brazilian Portuguese translation of Basic HTML and HTML5 (freeCodeCam…
dd2d84f 
…p#15439)

* Brazilian Portuguese translation of Basic HTML and HTML5
* Basic HTML and HTML reviewed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nmdoliveira @raisedadead @aferreira44 @camperbot @BerkeleyTrue