fix(signup): signup auth #15628
Merged
fix(signup): signup auth #15628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved user methods/extensions into one file. Tracked down `next method called more than once` error and setting headers after their sent. Let regular error handler handle api errors as well.
We are no longer allowing account creation through github
BerkeleyTrue
added
the
status: waiting review
|
Thanks @BerkeleyTrue I'll pull these down and test as soon as I am back tonite. If you are around, I'll hit you up in the chat. |
raisedadead
approved these changes
Jul 13, 2017
raisedadead
removed
the
status: waiting review
mhatout
pushed a commit
to mhatout/freeCodeCamp
that referenced
this pull request
Feb 9, 2018
* fix(models.user): Colocate all user methods Moved user methods/extensions into one file. Tracked down `next method called more than once` error and setting headers after their sent. Let regular error handler handle api errors as well. * feat(server.auth): Disable github account creation We are no longer allowing account creation through github * refactor(Auth): Move user identity link into models dir * feat(Disable link account login): This removes the ability to use a linked account t * feat(errorhandlers): Add opbeat, filter out handled error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add removes account creation using third party oauth.
Linking third party app will create user credential instead of user identity. Users linking their account before would then be able to login using that linked account.
Previously created accounts will still be able to use third party oauth to login.
If a linked account is associated with another user, it is instead attached to this user,
If a identity is no longer attached to a user, the identity is marked with a
isOrphanedproperty with the username of the user. This allows for easy lookup and deletion.Adds the ability to mark errors as handled so that they are not reported to production trackers.
Adds opbeat