Fixed tests in Waypoint: Use Comments to Clarify Code #1584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 6, 2015 00:20
I'm not sure if the tests are too vague - they allow to comment out way more than just the text specified - like the whole page..
greater than 0 instead of greater than or eqal to 1
Added check if the object isn't null and escaped quotes because text enclosed apostrophe
|
Is this tested on a local copy of FCC? |
|
Yes ;) |
|
Awesome work! |
|
Thanks, the same goes for You guys 👍 |
benmcmahon100
added a commit
that referenced
this pull request
Aug 5, 2015
Fixed tests in Waypoint: Use Comments to Clarify Code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added check for null and changed length check to larger than 0 (becuase we need only one comment to pass the tests)
Issue #1579