Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(LoopBack): Upgrade to LoopBack 3 #15892

Merged
merged 8 commits into from
Nov 27, 2017
Merged

feat(LoopBack): Upgrade to LoopBack 3 #15892

merged 8 commits into from
Nov 27, 2017

Conversation

raisedadead
Copy link
Member

@raisedadead raisedadead commented Sep 17, 2017

This upgrades LoopBack to v3.x.x

  • Update LoopBack version
  • Update use of REST error handler
  • Replace LoopBack middleware “getter” properties
  • Update models
  • Update models derived from PersistedModel
  • Explicitly add User model properties that were removed
  • Remove use of current-context methods, middleware, and configuration settings
  • Check request parameter encoding
  • Update use of promises
  • Check CORS configuration

More details of the checklist:
https://gist.github.com/raisedadead/22f7a38bb47204fded9b0877fde954ef

Closes #12780

@raisedadead raisedadead added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Sep 17, 2017
@freeCodeCamp freeCodeCamp deleted a comment from camperbot Sep 17, 2017
@raisedadead raisedadead added the status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. label Sep 17, 2017
@fizzvr
Copy link

fizzvr commented Sep 26, 2017

Why blocked? seems nice to upgrade the project, idk

@raisedadead
Copy link
Member Author

Why blocked? seems nice to upgrade the project, idk

It's a WIP actually but is blocked because some of other PR's especially those touching the models will have to land before this goes in.

Please feel free to pull down and test though.

@BerkeleyTrue BerkeleyTrue removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Oct 14, 2017
@camperbot
Copy link
Contributor

@raisedadead updated the pull request.

@raisedadead raisedadead added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. and removed status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. labels Nov 16, 2017
@camperbot
Copy link
Contributor

@raisedadead updated the pull request.

@raisedadead
Copy link
Member Author

I think this is ready for a QA. I have three items on the checklist that I am confident that I have done a review of, but unsure and would love a second set of eyes.

@BerkeleyTrue
Copy link
Contributor

Thanks for the PR. How much QA will this need. It seems to simple to be the only required changes.

@raisedadead
Copy link
Member Author

Honestly, this adds only the most minimum of changes needed to move to LB3, thanks to the fact that we do not use much of the features of Loopback.

You have already fixed a ton of issues with the error handling and the promise handling by customising it.

To, my best knowledge we should be safe, by merging this.
This is better than having the 2.x which is having tons of unhandled issues and isn't receiving any upgrades in a long time.

My advise though is to schedule this one of the incremental candidates in the RC plan, and roll back just one this if you do see issues, which I am hoping that you might not have to.

@BerkeleyTrue
Copy link
Contributor

The code looks good as far as I can see. Since loopback touches so many things I don't want to leave this till RC. I'm completely frustrated with loopbacks 2.0 LTS not fixing anything. I'll merge this in and update beta.

@BerkeleyTrue BerkeleyTrue merged commit 69fa4b3 into freeCodeCamp:staging Nov 27, 2017
@BerkeleyTrue BerkeleyTrue removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Nov 27, 2017
@raisedadead
Copy link
Member Author

Sure, thanks!

@raisedadead raisedadead deleted the feat/lb3-upgrade branch November 27, 2017 21:42
@BerkeleyTrue
Copy link
Contributor

BerkeleyTrue commented Nov 27, 2017

May have spoke to soon. I'm getting cannot find adler32 when trying to run node seed. Doesn't seem like the package lock file is complete. I'lll remedy this shortly
nvm, my mistake. I forgot to explicitly install the dev packages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants