-
-
Notifications
You must be signed in to change notification settings - Fork 36k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(LoopBack): Upgrade to LoopBack 3 #15892
feat(LoopBack): Upgrade to LoopBack 3 #15892
Conversation
Why blocked? seems nice to upgrade the project, idk |
It's a WIP actually but is blocked because some of other PR's especially those touching the models will have to land before this goes in. Please feel free to pull down and test though. |
@raisedadead updated the pull request. |
@raisedadead updated the pull request. |
I think this is ready for a QA. I have three items on the checklist that I am confident that I have done a review of, but unsure and would love a second set of eyes. |
Thanks for the PR. How much QA will this need. It seems to simple to be the only required changes. |
Honestly, this adds only the most minimum of changes needed to move to LB3, thanks to the fact that we do not use much of the features of Loopback. You have already fixed a ton of issues with the error handling and the promise handling by customising it. To, my best knowledge we should be safe, by merging this. My advise though is to schedule this one of the incremental candidates in the RC plan, and roll back just one this if you do see issues, which I am hoping that you might not have to. |
The code looks good as far as I can see. Since loopback touches so many things I don't want to leave this till RC. I'm completely frustrated with loopbacks 2.0 LTS not fixing anything. I'll merge this in and update beta. |
Sure, thanks! |
|
This upgrades LoopBack to v3.x.x
current-context
methods, middleware, and configuration settingsMore details of the checklist:
https://gist.github.com/raisedadead/22f7a38bb47204fded9b0877fde954ef
Closes #12780