fix(user): Update email pre-confirm config #15985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raisedadead
added
status: waiting review
|
@raisedadead updated the pull request. |
1 similar comment
|
@raisedadead updated the pull request. |
Earlier we did not need emails for everyone, this is not the case anymore. We now require emails, and all other auth mechanisms are now deprecated for new users.
|
@raisedadead updated the pull request. |
raisedadead
changed the title
raisedadead
added
status: waiting review
|
@raisedadead updated the pull request. |
|
@BerkeleyTrue I just talked with @raisedadead and he said this is ready to QA - could you take a quick look and comment or merge if it's ready? |
| // work around should let us sneak by | ||
| // see: | ||
| // https://github.com/strongloop/loopback/issues/1137#issuecomment-109200135 | ||
| delete User.validations.email; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
BerkeleyTrue
removed
the
status: waiting review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This request aims to make the following changes to the user model and email auth:
Refactor common code for creating verification tokens for update and login paths.This can be taken up in a separate pull request.Closes #15822