Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(UI): Add new congratulations messages and remove some #16110

Conversation

QuincyLarson
Copy link
Contributor

Pre-Submission Checklist

  • Your pull request targets the staging branch of freeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Description

Some campers found the "We underestimated you" congratulatory line to be inappropriate. I removed it and added a few new ones.

@QuincyLarson QuincyLarson added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Nov 21, 2017
Copy link
Member

@raisedadead raisedadead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Quick query: Where do we plan to use the calls-to-action ?

Thanks @QuincyLarson

@QuincyLarson
Copy link
Contributor Author

@raisedadead We may start letting campers turn on browser notifications to remind them to come back and code. Like once a day a noon, it could pop up a browser notification that takes them back to their current challenge. This feature is just an idea at this point, but I didn't think it would hurt to add my proposed call to action phrases to the document.

@raisedadead
Copy link
Member

Oh yes, totally. I was just curious about the addition. 😃 !

@raisedadead raisedadead merged commit 52c9982 into freeCodeCamp:staging Nov 25, 2017
@QuincyLarson
Copy link
Contributor Author

@raisedadead thanks for QA'ing this.

mhatout pushed a commit to mhatout/freeCodeCamp that referenced this pull request Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants