-
-
Notifications
You must be signed in to change notification settings - Fork 36.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(challenges): Highlight current challenge #16982
Merged
Bouncey
merged 1 commit into
freeCodeCamp:staging
from
love1024:feature/highlight-current-challenge
Apr 18, 2018
Merged
feat(challenges): Highlight current challenge #16982
Bouncey
merged 1 commit into
freeCodeCamp:staging
from
love1024:feature/highlight-current-challenge
Apr 18, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bouncey
suggested changes
Apr 10, 2018
common/app/Map/Challenge.jsx
Outdated
@@ -29,7 +30,7 @@ function makeMapStateToProps(_, { dashedName }) { | |||
userSelector, | |||
challengeMapSelector, | |||
( | |||
{ challengeMap: userChallengeMap }, | |||
{ challengeMap: userChallengeMap, currentChallengeId}, |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
highlight the currently selected challenge Closes freeCodeCamp#16902 feat(challenges): Use of params dashed to get current challenge Closes freeCodeCamp#16902
@love1024 updated the pull request. |
8285ab4
to
80d7e70
Compare
@love1024 updated the pull request. |
Bouncey
approved these changes
Apr 18, 2018
Brilliant! Thanks @love1024 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
platform: learn
UI side of the client application that needs familiarity with React, Gatsby etc.
status: waiting review
To be applied to PR's that are ready for QA, especially when additional review is pending.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
highlight the currently selected challenge
Closes #16902
Pre-Submission Checklist
staging
branch of freeCodeCamp.fix/
,feature/
, ortranslate/
(e.g.fix/signin-issue
)npm test
. Usegit commit --amend
to amend any fixes.Type of Change
Checklist:
Closes #16902
Description