Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(challenges): Highlight current challenge #16982

Merged

Conversation

love1024
Copy link
Contributor

highlight the currently selected challenge

Closes #16902

Pre-Submission Checklist

  • Your pull request targets the staging branch of freeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

  • Tested changes locally.
  • Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes #16902

Description

@raisedadead raisedadead added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Mar 29, 2018
@raisedadead raisedadead added the platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. label Apr 3, 2018
@@ -29,7 +30,7 @@ function makeMapStateToProps(_, { dashedName }) {
userSelector,
challengeMapSelector,
(
{ challengeMap: userChallengeMap },
{ challengeMap: userChallengeMap, currentChallengeId},

This comment was marked as off-topic.

This comment was marked as off-topic.

highlight the currently selected challenge

Closes freeCodeCamp#16902

feat(challenges): Use of params dashed to get current challenge

Closes freeCodeCamp#16902
@camperbot
Copy link
Contributor

@love1024 updated the pull request.

@love1024 love1024 force-pushed the feature/highlight-current-challenge branch from 8285ab4 to 80d7e70 Compare April 11, 2018 09:23
@camperbot
Copy link
Contributor

@love1024 updated the pull request.

@Bouncey
Copy link
Member

Bouncey commented Apr 18, 2018

Brilliant! Thanks @love1024

@Bouncey Bouncey merged commit 2f95c9f into freeCodeCamp:staging Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants