Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: blockquote-formatting-in-challenges #17590

Merged
merged 1 commit into from
Jun 17, 2018
Merged

fix: blockquote-formatting-in-challenges #17590

merged 1 commit into from
Jun 17, 2018

Conversation

moT01
Copy link
Member

@moT01 moT01 commented Jun 15, 2018 •
edited

Pre-Submission Checklist

  • Your pull request targets the staging branch of freeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)

Checklist:

We're here to help! -->

  • Tested changes locally.
  • Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes #17515

Description

Added whitespace in the blockquote area of the description for all the challenges that needed formatting (as described in the issue) - I went through it pretty thoroughly, it looks good

@raisedadead raisedadead added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. labels Jun 15, 2018
@scissorsneedfoodtoo scissorsneedfoodtoo merged commit 412980c into freeCodeCamp:staging Jun 17, 2018
@scissorsneedfoodtoo
Copy link
Contributor

👍 👍 Awesome! Everything LGTM! 👍 👍

Thank you for making all of these changes, @moT01. I've always wondered about the best way to add spacing to the blockquotes and other parts of the description since multiple spaces are escaped. This definitely seems like the easiest, most straightforward way.

@moT01 moT01 deleted the fix/blockquote-formatting-in-challenges branch June 17, 2018 14:16
ValeraS pushed a commit to ValeraS/freeCodeCamp that referenced this pull request Oct 12, 2018
@moT01 @raisedadead
fix: blockquote-formatting-in-challenges (freeCodeCamp#17590)
d31e0a3
ValeraS pushed a commit to ValeraS/freeCodeCamp that referenced this pull request Oct 12, 2018
@semantic-release-bot
chore(release): 1.2.0 [skip ci]
5a58ad2 
# [1.2.0](freeCodeCamp/curriculum@v1.1.3...v1.2.0) (2018-06-19)

### Bug Fixes

* **challenges:** Fix typo in security challenge ([freeCodeCamp#17608](https://github.com/freeCodeCamp/curriculum/issues/17608)) ([1573455](freeCodeCamp/curriculum@1573455))
* blockquote-formatting-in-challenges ([freeCodeCamp#17590](https://github.com/freeCodeCamp/curriculum/issues/17590)) ([d31e0a3](freeCodeCamp/curriculum@d31e0a3))

### Features

* **interview-prep:** Porting Rosetta problems ([freeCodeCamp#17537](https://github.com/freeCodeCamp/curriculum/issues/17537)) ([a133a3f](freeCodeCamp/curriculum@a133a3f))

### Reverts

* "test(challenges): Corrected expected average value" ([freeCodeCamp#17568](https://github.com/freeCodeCamp/curriculum/issues/17568)) ([20fac4e](freeCodeCamp/curriculum@20fac4e))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scissorsneedfoodtoo scissorsneedfoodtoo Awaiting requested review from scissorsneedfoodtoo

Assignees
No one assigned
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@moT01 @scissorsneedfoodtoo @raisedadead