Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(heat-map): Show last 8 months of activity #18004

Merged
merged 1 commit into from Aug 29, 2018

Conversation

flower17
Copy link
Contributor

Pre-Submission Checklist

  • Your pull request targets the staging branch of freeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

Closes #17320

Description

Fixed issue with HeatMap showing only the first 8 months of user's activity:
#17320

All unit tests passed:
total: 1481
passing: 1481
duration: 17s

Tested the fix locally using test heat map data instead of calendar data coming via props to HeatMap.jsx. Test heat map data contains dates starting from Jul 17 2016 till Jul 17 2018 (2 years range), and tests confirm that there is up to 8 last months of activity is displayed on a heat map.

{1468704955: 2,
1497216955: 4,
1500240955: 3,
1504128955: 1,
1505856955: 1,
1507584955: 4,
1508448955: 4,
1509312955: 4,
1509744955: 4,
1511040955: 4,
1512682555: 4,
1512768955: 4,
1513200955: 4,
1514928955: 4,
1515792955: 1,
1517520955: 2,
1519248955: 1,
1519335355: 2,
1519421755: 3,
1519508155: 4,
1519594555: 5,
1523136955: 1,
1524000955: 1,
1524087355: 1,
1527456955: 2,
1527888955: 1,
1528752955: 3,
1529184955: 1,
1529616955: 4,
1530480955: 1,
1531344955: 5,
1531690555: 1}

@flower17
Copy link
Contributor Author

Hi @vikaskyadav, please take a look once you have a chance.

This is a new pull request instead of #17893 - created a new one since had issues with amending changes to existing pull request.
Contains same changes as closed pull request(17893), also added storage of the expression result as constant, as you have suggested.

Thank you.

@raisedadead raisedadead merged commit f0e5633 into freeCodeCamp:staging Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants