fix(utils): unify common utility scripts

[ojeytonwilliams]

Unify common scripts like dasherize.

[paulywill]

@raisedadead @Bouncey Why is the PR still open if labeled blocked?

[paulywill]

Opps... wrong button

[raisedadead]

Hi @ojeytonwilliams @paulywill this is change that we are evaluating for inclusion.

We have merged the learn platform in this main repo. So, it needs to be decided where we need to put up some common utils like such as this file.

We haven't gotten around to this, hence the blocked status. The action is on the @freeCodeCamp/dev-team for now.

Thanks.

[thecodingaviator]

@raisedadead What are we thinking about this Pr a.t.m?

[RandellDawson]

@ValeraS Is this PR still needed, since you made the recent changes to dasherize? The only other thing I see is changes to nameify function.

[ojeytonwilliams]

@RandellDawson I think an updated version of this PR is needed, since there are still several instances of dasherize and nameify. dasherize is a bit tricky because some of which are slightly different!

Nonetheless, if they can be unified, presumably they should be. Perhaps in a new common utils directory.

[raisedadead]

Are we able to revisit or close this @ojeytonwilliams ?

[ojeytonwilliams]

Well, this is stale to the point of useless, but I still think we should DRY out this stuff.

I've taken another look at the three dasherize functions and they all have exactly the same functionality. They're just written slightly differently.

Is there any reason not to just put a single util in the root dir and have the client, server and curriculum all use that?

[raisedadead]

Is there any reason not to just put a single util in the root dir and have the client, server and curriculum all use that?

There is none. Please go ahead with the refactor if you are interested.

[gitpod-io]

[raisedadead]

Hi @ojeytonwilliams I like this, and going forth we should probably using this structure for our utils. Do you mind throwing some unit tests in?

Once you do please, feel free to hit the merge button.

[ojeytonwilliams]

@raisedadead are these tests what you had in mind? They made me realise that " a title " becomes "-a-title--", which doesn't look great. Perhaps we should trim the strings first.

[raisedadead]

These tests are perfect and as you seem to have found a use case where we do need to trim the spaces.

[RandellDawson]

LGTM

[raisedadead]

You sir rock!