Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix - typo in contribute.md #18252

Closed
wants to merge 1 commit into from
Closed

fix - typo in contribute.md #18252

wants to merge 1 commit into from

Conversation

spencer1573
Copy link

"your" -> "you"

one thing... I couldn't find the staging branch... is that supposed to be "next"? I'm a little confused.

Pre-Submission Checklist

  • Your pull request targets the staging branch of freeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

  • Tested changes locally.
  • Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes #XXXXX

Description

@ArielLeslie
Copy link
Contributor

This typo is fixed in at least one pre-existing PR (#18251 )

@spencer1573
Copy link
Author

great catch @ArielLeslie. I'll undo this pull request.

@spencer1573 spencer1573 closed this Oct 4, 2018
@RandellDawson RandellDawson added the invalid Invalid issue or PR. Should be closed. Mainly used to invalidate low-effort hacktoberfest PR's label Oct 29, 2018
@fcsouza fcsouza mentioned this pull request Apr 5, 2024
Open
@simha95 simha95 mentioned this pull request Apr 6, 2024
Open
@MaxMood96 MaxMood96 mentioned this pull request Apr 6, 2024
Open
@susanstdemos susanstdemos mentioned this pull request Apr 6, 2024
Open
@bobby-lin bobby-lin mentioned this pull request Apr 6, 2024
Open
@susanstdemos susanstdemos mentioned this pull request Apr 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
invalid Invalid issue or PR. Should be closed. Mainly used to invalidate low-effort hacktoberfest PR's
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@spencer1573 @ArielLeslie @RandellDawson