Challenge point save fix. #200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
|
Hi James, thank you for the pull request. We've already fixed this properly on a different branch that will hopefully be pulled into production in the next few days. All points will be representative of challenges and bonfires completed. The challenges themselves will be replaced with our new coursewares. Sorry it's taking so long to merge this branch into production. It's a big branch with Loopback, React, IO.JS and a lot of other technologies and we're not planning to have crazy branches like this holding up feature development in the future. |
This was referenced Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #194.
Completing a Challenge was resetting user.points to the total number of Challenges completed causing Bonfire points to be discarded.
user.challengesCompleted wasn't being used so I updated the code to use it to track completed Challenges. I'm not sure if I went the best way using it though. I copied the user.challengesHash setting to mirror the challenges since I didn't want to mess with code that was already being used. So whenever you add a new Challenge in the future you will need to add the same to challengesCompleted.