Dev server crash fix #204
Merged
Dev server crash fix #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
| res.send({"trello": trello}); | ||
| }); | ||
| }, | ||
| bloggerCalls: function(req, res) { | ||
| request('https://www.googleapis.com/blogger/v3/blogs/2421288658305323950/posts?key=' + secrets.blogger.key, function (err, status, blog) { | ||
| blog = blog.length > 100 ? JSON.parse(blog) : ''; | ||
| blog = (status && status.statusCode == 200) ? JSON.parse(blog) : ''; | ||
| res.send({ |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Sweet! Looks good. Thanks. Soon as I can test it I will merge. |
|
Sorry haven't got around to this yet. Will do by the end of the day. |
|
@BerkeleyTrue Are you still QA'ing this? |
|
Sorry dude. I have been on a support ticket for a client all day. Can you take this one? |
|
on it now. connects #199 |
|
Works. There are a bunch more in this file that need to be handled properly. Will merge though as these work. |
This was referenced Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #199.
Checks that the request returned a 200. API fails return 400/401.
THIS NEEDS TO BE TESTED WITH REAL API KEYS. I don't have any.