Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated index.md #22280

Merged
merged 4 commits into from
Nov 19, 2018
Merged

Updated index.md #22280

merged 4 commits into from
Nov 19, 2018

Conversation

ritulsriva
Copy link
Contributor

Added more resources to the article

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.

Closes #XXXXX

Added more resources to the article
@RandellDawson RandellDawson added the invalid Invalid issue or PR. Should be closed. Mainly used to invalidate low-effort hacktoberfest PR's label Oct 19, 2018
Copy link
Member

@RandellDawson RandellDawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move the following to be outside the code block:

You can refer to this article for deeper insight into regression  
https://www.analyticsvidhya.com/blog/2017/06/a-comprehensive-guide-for-linear-ridge-and-lasso-regression/

@RandellDawson RandellDawson removed the invalid Invalid issue or PR. Should be closed. Mainly used to invalidate low-effort hacktoberfest PR's label Oct 19, 2018
Moved the lines out of the code block as requested
Copy link
Contributor Author

@ritulsriva ritulsriva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added the resource article outside the codeblock which I mistakenly inserted inside the codeblock in my previous commit.

@Manish-Giri Manish-Giri added the status: merge conflict To be applied to PR's that have a merge conflict and need updating label Nov 6, 2018
@cmccormack cmccormack dismissed RandellDawson’s stale review November 19, 2018 03:00

Commit was added to correct issue

Copy link
Member

@cmccormack cmccormack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thank you for your contribution!

@cmccormack cmccormack added status: waiting for CI and removed status: merge conflict To be applied to PR's that have a merge conflict and need updating labels Nov 19, 2018
@moT01 moT01 merged commit a7616e7 into freeCodeCamp:master Nov 19, 2018
@moT01
Copy link
Member

moT01 commented Nov 19, 2018

Looks good @ritulsriva, thanks for contributing to freeCodeCamp! In the future, be sure to fill out the checklist in the PR template provided. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants