Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: test curriculum challenges #24180

Merged
merged 6 commits into from Oct 23, 2018
Merged

fix: test curriculum challenges #24180

merged 6 commits into from Oct 23, 2018

Conversation

ValeraS
Copy link
Contributor

@ValeraS ValeraS commented Oct 20, 2018

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.

Closes #XXXXX

tests only challenges for the English language

@ValeraS ValeraS added scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: tests labels Oct 20, 2018
@ValeraS ValeraS requested review from raisedadead, Bouncey and a team October 20, 2018 10:47
raisedadead
raisedadead requested changes Oct 20, 2018
View reviewed changes
curriculum/test-challenges.js Outdated Show resolved Hide resolved
@ValeraS ValeraS force-pushed the fix/test-curriculum-challenges branch from ca5e32b to da2a43c Compare October 20, 2018 15:48
@ValeraS ValeraS mentioned this pull request Oct 20, 2018
Merged
5 tasks
raisedadead
raisedadead approved these changes Oct 20, 2018
View reviewed changes
Copy link
Member

@raisedadead raisedadead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work as usual @ValeraS !

@raisedadead
Copy link
Member

I am going to pull this down to test on my fork for the CI. Other than that we are good to go.

@raisedadead
Copy link
Member

raisedadead commented Oct 20, 2018 •
edited

@ValeraS looks like this is great. I created https://github.com/raisedadead/freeCodeCamp/pull/19 on my fork which avoids the build backlog.

@raisedadead
Copy link
Member

The build seems to have caught all that is required @Bouncey

@ValeraS

IDK, and this not a concern of your PR per say, but can we get rid of the stack somehow:

https://travis-ci.org/raisedadead/freeCodeCamp/builds/444145777#L5144-L5156

@RandellDawson @scissorsneedfoodtoo @beaucarnes
We would need to go thru the build and fix the linting in challenge tests.

/cc @tchaffee

@ValeraS ValeraS force-pushed the fix/test-curriculum-challenges branch from da2a43c to 924672f Compare October 21, 2018 07:58
@ValeraS
Copy link
Contributor Author

ValeraS commented Oct 21, 2018

Added syntax check of tests for challenges without a solution.

@ValeraS
fix(curriculum): fix broken tests
f4ceafb
@ValeraS
test(curriculum): test challenges
3fcbdfd 
- test html challenges with the use of JSDOM
- check syntax of tests for modern challenges
@ValeraS
fix(curriculum): fix solutions of html challenges
09fc6b7
@scissorsneedfoodtoo
Copy link
Contributor

Everything LGTM! Awesome job, @ValeraS. Just ran the test locally and everything passes without a hitch.

@raisedadead raisedadead merged commit e099d64 into freeCodeCamp:master Oct 23, 2018
@ValeraS ValeraS deleted the fix/test-curriculum-challenges branch October 26, 2018 13:30
vdkhadke pushed a commit to vdkhadke/freeCodeCamp that referenced this pull request Oct 28, 2018
@ValeraS @vdkhadke
fix: test curriculum challenges (freeCodeCamp#24180)
e007f40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raisedadead raisedadead raisedadead approved these changes

@Bouncey Bouncey Awaiting requested review from Bouncey

Assignees
No one assigned
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ValeraS @raisedadead @scissorsneedfoodtoo