Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create chart.js #26904

Merged
merged 3 commits into from
Jan 30, 2019
Merged

Create chart.js #26904

merged 3 commits into from
Jan 30, 2019

Conversation

johnfolder01
Copy link
Contributor

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.

Closes #XXXXX

@johnfolder01 johnfolder01 requested a review from a team October 23, 2018 11:47
@camperbot
Copy link
Contributor

Hi @johnfolder01,

Thanks for this pull request (PR).

Unfortunately, these changes have failed some of our recommended guidelines. Please correct the issue(s) listed below, so we can consider merging your content.

Issue Description File Path
1 chart.js is not a valid file name, please use index.md guide/english/javascript/chart.js

P.S: I am just friendly bot. You should reach out to the Contributors Chat room for more help.

@camperbot camperbot added scope: guide status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP labels Nov 13, 2018
@RandellDawson RandellDawson removed the status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP label Nov 14, 2018
@RandellDawson
Copy link
Member

I made the changes suggested by camperBot on your behalf.

LGTM

@RandellDawson RandellDawson self-assigned this Nov 14, 2018
@RandellDawson RandellDawson removed their assignment Nov 14, 2018
@raisedadead raisedadead removed the request for review from a team November 16, 2018 15:58
@RandellDawson RandellDawson merged commit d12af36 into freeCodeCamp:master Jan 30, 2019
@RandellDawson
Copy link
Member

Congrats @johnfolder01 on your first pull request (PR)! 🎉

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 📝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants