Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved the Instructions text into correct place, added Caution text #29742

Closed
wants to merge 1 commit into from

Conversation

alittlepickle
Copy link
Contributor

I moved the Instructions text into the proper section. Added a cautionary text since the import issue with Glitch persists, and there is no alert to the user when that happens.

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.
  • My article does not contain shortened URLs or affiliate links.

@camperbot camperbot added scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: need to test locally labels Nov 13, 2018
@RandellDawson
Copy link
Member

Closed and Reopened this PR to attempt to resolve a specific Travis build failure.

@RandellDawson
Copy link
Member

Thank you for opening this pull request.

This is a standard message notifying you that we’ve reviewed your pull request and have decided not to merge it. We would welcome future pull requests from you.

Reason: See the following list of why we have closed this PR. Please feel free to create a new PR with the suggestions made below:

  1. While your intentions are good regarding moving the instructions to the right section, you did not remove the existing text with the instructions from the description section.
    2 We do not want to have instructions which have a caution/disclaimer describing a work around for a possible issue. Instead, I suggest creating an issue (if there is not already one) and report this problem there.
  2. The file which you have made changes to is no longer named the same. Please resync your fork and find the new location of the file here.

Thank you and happy coding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants